Skip to content

Replacing currently broken ICC Latest C++17 with C++14. - #3551

Merged
henryiii merged 6 commits into
pybind:masterfrom
rwgk:ci_issues
Dec 21, 2021
Merged

Replacing currently broken ICC Latest C++17 with C++14.#3551
henryiii merged 6 commits into
pybind:masterfrom
rwgk:ci_issues

Conversation

@rwgk

@rwgkrwgk commented Dec 13, 2021

Copy link
Copy Markdown
Collaborator

Description

This restores fully functional CI against master.

The C++17 build was working with

  • Intel 2021.4.0.20210910 (/opt/intel/oneapi/compiler/2021.4.0/linux/bin/intel64/icpc)

but started failing with

  • Intel 2021.5.0.20211109 (/opt/intel/oneapi/compiler/2022.0.0/linux/bin/intel64/icpc)

Related PRs for reporting errors to Intel:

Suggested changelog entry:

@rwgkrwgk closed this Dec 13, 2021
@rwgkrwgk reopened this Dec 13, 2021
@rwgkrwgk changed the title Trivial change.Replacing currently broken ICC Latest C++17 with C++14.Dec 16, 2021
@rwgk
rwgk requested a review from henryiiiDecember 16, 2021 04:17
@henryiii

Copy link
Copy Markdown
Collaborator

Looks like this is broken again. I'd be fine to roll this back to C++14 for now until Intel gets this fixed. Has it been reported to Intel?

@rwgkrwgk closed this Dec 20, 2021
@rwgk

rwgk commented Dec 20, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Trying again in the exact same state to see if the 3.9-dbg (deadsnakes) • Valgrind • x64 failure reproduces.

@rwgkrwgk reopened this Dec 20, 2021
@rwgk
rwgk marked this pull request as ready for review December 20, 2021 19:26
@rwgk

rwgk commented Dec 20, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Hi @henryiii, I'll revive #3553 after this PR is merged, for reporting to Intel.

@henryiii

Copy link
Copy Markdown
Collaborator

Added a temporary fix for pypa/setuptools#2946.

@henryiiihenryiii reopened this Dec 20, 2021
@henryiii
henryiii merged commit b3d9c35 into pybind:masterDec 21, 2021
@github-actionsgithub-actionsBot added the needs changelog Possibly needs a changelog entry label Dec 21, 2021
@henryiiihenryiii removed the needs changelog Possibly needs a changelog entry label Dec 21, 2021
@rwgk
rwgk deleted the ci_issues branch December 22, 2021 22:35
@rwgkrwgk mentioned this pull request Dec 23, 2021
@rwgkrwgk mentioned this pull request Feb 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rwgk@henryiii