Skip to content

Document how to bind templates - #3665

Merged
rwgk merged 1 commit into
pybind:masterfrom
robotpy:template-docs
Jan 29, 2022
Merged

Document how to bind templates#3665
rwgk merged 1 commit into
pybind:masterfrom
robotpy:template-docs

Conversation

@virtuald

@virtualdvirtuald commented Jan 29, 2022

Copy link
Copy Markdown
Contributor

I was very surprised that the documentation doesn't explicitly call out how to bind templates. While it's fairly obvious, it may not be to those minimally familiar with C++.

rwgk
rwgk approved these changes Jan 29, 2022
View reviewed changes

@rwgkrwgk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment threaddocs/advanced/classes.rst Outdated
Comment threaddocs/advanced/functions.rst Outdated
@rwgk

rwgk commented Jan 29, 2022

Copy link
Copy Markdown
Collaborator

Merging, thanks Dustin!

@rwgk
rwgk merged commit 1779288 into pybind:masterJan 29, 2022
@github-actionsgithub-actionsBot added the needs changelog Possibly needs a changelog entry label Jan 29, 2022
@henryiiihenryiii removed the needs changelog Possibly needs a changelog entry label Jan 31, 2022
@virtualdvirtuald mentioned this pull request Feb 2, 2022
Merged
@virtuald
virtuald deleted the template-docs branch September 12, 2022 02:43
@rwgkrwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgkrwgkrwgk approved these changes
@Skylion007Skylion007Skylion007 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@virtuald@rwgk@Skylion007@henryiii