Uh oh!
There was an error while loading. Please reload this page.
tests: use 'build' in tests instead of running setup.py - #3734
Conversation
Co-authored-by: Anderson Bravalheri <andersonbravalheri@gmail.com>
rwgk
left a comment
There was a problem hiding this comment.
Out of my wheelhouse but LGTM.
Would be nice to add a sentence or two to the PR description, for build muggles like myself:
- Was it the Python 2 or 3.5 drop that made this possible?
- Why are we keeping setup.py? (Needed externally?)
henryiii
commented
Feb 14, 2022
No, don't think it was the Python drop, it was just... Not sure why I used raw setup.py commands before, probably didn't realize the proper way to do it. Though the drop does make it easier to just add a specific build version. |
Description
Use build instead of direct setup.py commands in our tests. Mostly by @abravalheri, pulled from #3711.
Suggested changelog entry:
* Avoid ``setup.py <command>`` usage in internal tests.