Skip to content

[smart_holder] Debugging test_cross_module_exception_translator issue - #4053

Closed
rwgk wants to merge 8 commits into
pybind:smart_holderfrom
rwgk:debugging
Closed

[smart_holder] Debugging test_cross_module_exception_translator issue#4053
rwgk wants to merge 8 commits into
pybind:smart_holderfrom
rwgk:debugging

Conversation

@rwgk

@rwgkrwgk commented Jul 8, 2022

Copy link
Copy Markdown
Collaborator

Description

IGNORE this PR! Debugging came to a conclusion under PR #4054.

Suggested changelog entry:

rwgk added 6 commits July 7, 2022 20:51
To probe environment/toolchain/platform-specific behavior under the exact same conditions as normal tests.
(An earlier version of this code was used to inform PR pybind#4043.)
…and CUDA `test_cross_module_exception_translator` failures).
…s action un-helpfully removed the added noqa).
…files, only setting the module docstring and doing nothing else.
@rwgkrwgk closed this Jul 8, 2022
@rwgk

rwgk commented Jul 8, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Forgot to select the smart_holder branch.

@rwgkrwgk reopened this Jul 8, 2022
@rwgk
rwgk changed the base branch from master to smart_holderJuly 8, 2022 19:17
@rwgkrwgk closed this Jul 8, 2022
@rwgkrwgk reopened this Jul 8, 2022
@rwgk

rwgk commented Jul 8, 2022

Copy link
Copy Markdown
CollaboratorAuthor

It let me change the target branch only on the open PR. Oh well.

rwgk added a commit to rwgk/pybind11 that referenced this pull request Jul 8, 2022
@rwgkrwgk closed this Jul 8, 2022
@rwgk
rwgk deleted the debugging branch July 8, 2022 23:37
@rwgkrwgk mentioned this pull request Feb 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@rwgk