Uh oh!
There was an error while loading. Please reload this page.
fix(cmake): use case-insensitive CMAKE_BUILD_TYPE comparisons - #4078
Merged
Conversation
Skylion007
approved these changes
Jul 18, 2022
henryiii
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
$<CONFIG:tgt>generator expression is case-insensitive, this change aligns the behavior of the explicitCMAKE_BUILD_TYPEcomparisons used to determine whether debug symbols should be stripped.I ran into this problem with a codebase that uses
DEBUGinstead ofDebugforCMAKE_BUILD_TYPE, so debug symbols get stripped for debug builds.Suggested changelog entry: