Uh oh!
There was an error while loading. Please reload this page.
chore: Delete copy ctor/assign for GIL RAIIs - #4183
Merged
Merged
Conversation
henryiii
approved these changes
Sep 17, 2022
rwgk
approved these changes
Sep 17, 2022
rwgk
left a comment
Collaborator
There was a problem hiding this comment.
Nice!
It might be good to add the two lines to gil_scoped_acquire_local in detail/internals.h as well. Not that it matters for the code as is, but these kind of fragments tend to get copied around. Having it complete there as well, the oversight/omission won't spread.
Skylion007
marked this pull request as ready for review
September 19, 2022 16:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed some of the GIL RAIIs still had their potential copy assignment operators so I made sure they were explicitly deleted. This should prevent bugprone behavior of trying to copy them / move them around.
Suggested changelog entry: