Uh oh!
There was an error while loading. Please reload this page.
bugfix: Add error checking to list append and insert - #4208
Merged
Conversation
rwgk
approved these changes
Oct 3, 2022
rwgk
left a comment
Collaborator
There was a problem hiding this comment.
For .insert(): wow, how did this go unnoticed for so long? Great catch!
It would be ideal to add a test for the .insert() failure. I guess it's just a line or two.
Skylion007
commented
Oct 3, 2022
CollaboratorAuthor
Whelp, I was wrong. a= []
a.insert(999, 1)
a== [1,]That is perfectly valid and does not raise any exceptions. Yeah Python! :/ So yeah, this exception will only be raised on out of memory errors then. I've updated the PR description. |
rwgk
approved these changes
Oct 3, 2022
rwgk
left a comment
Collaborator
There was a problem hiding this comment.
That is perfectly valid and does not raise any exceptions.
Oh! I would not have guessed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was looking through our python bindings and noticed we didn't do any error checking for insert or append in the list object in pytypes.h. While the only way append or insert can fail if is the list is unable to grow (allocation failure)This change will properly propagate exceptions for both these methods in this rare case.
Suggested changelog entry: