Skip to content

chore: steal arg_v.value from copied arg in unpacking_collector - #4219

Merged
Skylion007 merged 1 commit into
pybind:masterfrom
Skylion007:remove-argv-copy-in-process
Oct 6, 2022
Merged

chore: steal arg_v.value from copied arg in unpacking_collector#4219
Skylion007 merged 1 commit into
pybind:masterfrom
Skylion007:remove-argv-copy-in-process

Conversation

@Skylion007

Copy link
Copy Markdown
Collaborator

Description

  • I was looking through the include cast and noticed we could steal the arg_v.value for the copied arg in the process list. This should remove one inc-ref / dec-ref from py::object and therefore potentially speed up the processing of a function with lots of specified arg_v values.

Suggested changelog entry:

* chore: optimize unpacking_collector when processing arg_v arguments.

rwgk
rwgk approved these changes Oct 6, 2022
@Skylion007
Skylion007 merged commit 864ed11 into pybind:masterOct 6, 2022
@github-actionsgithub-actionsBot added the needs changelog Possibly needs a changelog entry label Oct 6, 2022
@henryiiihenryiii removed the needs changelog Possibly needs a changelog entry label Oct 20, 2022
@rwgkrwgk mentioned this pull request Feb 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Skylion007@rwgk@henryiii