Skip to content

Replace ubuntu-latest with ubuntu-22.04 - #4382

Merged
rwgk merged 5 commits into
pybind:masterfrom
rwgk:py36_eol
Dec 5, 2022
Merged

Replace ubuntu-latest with ubuntu-22.04#4382
rwgk merged 5 commits into
pybind:masterfrom
rwgk:py36_eol

Conversation

@rwgk

@rwgkrwgk commented Dec 4, 2022

Copy link
Copy Markdown
Collaborator

Description

Using previous configure.yml logs to pin-point when ubuntu-latest changed from 20.04 to 22.04:

  • 2022-12-02T01:51:20.8819798Z Image: ubuntu-20.04 — last success
  • 2022-12-02T13:46:45.3899378Z Image: ubuntu-22.04 — first failure

There are multiple problems:

  • configure.yml: Python 3.6 no longer available (for cmake 3.4 testing). When changing to Python 3.9, there is boost compilation error (related to variant or boost/mpl).
  • configure.yml: cmake 3.4 no longer working because of missing libidn11.
  • ci.yml: Python 3.6 no longer available; valgrind testing broken.

General: it does not make much sense to test Python 3.6, cmake 3.4, valgrind with Python 3.9 (all very or somewhat outdated) on the "tatest" platform.

Opinion: it will be best to pin those indefinitely, modernize valgrind testing with the latest platform & Python (when someone gets to it), and drop cmake 3.4 and Python 3.6 entirely.

Conservative resolution: change ubuntu-latest to ubuntu-20.04, but only as required to resolve breakages.

Suggested changelog entry:

@rwgkrwgk changed the title Replace jobs failing due to Python 3.6 EOLReplace ubuntu-latest with ubuntu-22.04Dec 4, 2022
@rwgk

rwgk commented Dec 4, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Commit cdfd995 confirms that we get back to all-green by systematically changing all ubuntu-latest to ubuntu-20.04.

I'll try to make the changes more selective, to only address breakages.

@rwgk

rwgk commented Dec 5, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Thanks @Skylion007! I wrote up the rationale in the PR description.

@rwgk
rwgk marked this pull request as ready for review December 5, 2022 03:39
@rwgk
rwgk requested a review from henryiii as a code ownerDecember 5, 2022 03:39
@rwgk
rwgk merged commit 5b55f8f into pybind:masterDec 5, 2022
@rwgk
rwgk deleted the py36_eol branch December 5, 2022 03:39
@github-actionsgithub-actionsBot added the needs changelog Possibly needs a changelog entry label Dec 5, 2022
@rwgkrwgk removed the needs changelog Possibly needs a changelog entry label Dec 5, 2022
@rwgkrwgk mentioned this pull request Feb 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rwgk@Skylion007