Skip to content

Fix some issuses detected by static analyzer - #4440

Merged
henryiii merged 3 commits into
pybind:masterfrom
cyyever:various_fix
Jan 3, 2023
Merged

Fix some issuses detected by static analyzer#4440
henryiii merged 3 commits into
pybind:masterfrom
cyyever:various_fix

Conversation

@cyyever

Copy link
Copy Markdown
Contributor

No description provided.

rwgk
rwgk approved these changes Jan 3, 2023
Comment threadinclude/pybind11/pytypes.h
@rwgk

rwgk commented Jan 3, 2023

Copy link
Copy Markdown
Collaborator

BTW: The only one CI failure here is addressed by #4438

I.e. good to ignore here.

@henryiii
henryiii merged commit e3e24f3 into pybind:masterJan 3, 2023
@github-actionsgithub-actionsBot added the needs changelog Possibly needs a changelog entry label Jan 3, 2023
henryiii pushed a commit that referenced this pull request Jan 3, 2023
* fix incorrect variable check
* remove duplicated check
* remove unneeded const cast
@henryiiihenryiii removed the needs changelog Possibly needs a changelog entry label Jan 3, 2023
@cyyever
cyyever deleted the various_fix branch January 4, 2023 01:25
@rwgkrwgk mentioned this pull request Feb 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cyyever@rwgk@Skylion007@henryiii