Skip to content

Ensure import pybind11_tests traceback is shown. - #4455

Merged
Skylion007 merged 1 commit into
pybind:masterfrom
rwgk:import_pybind11_tests_traceback
Jan 14, 2023
Merged

Ensure import pybind11_tests traceback is shown.#4455
Skylion007 merged 1 commit into
pybind:masterfrom
rwgk:import_pybind11_tests_traceback

Conversation

@rwgk

@rwgkrwgk commented Jan 14, 2023

Copy link
Copy Markdown
Collaborator

Description

Not seeing the primary failure reason can be (has been) very confusing during development. (Concretely, I lost good chunks of time while working on PRs #1895 and #4329.)

Suggested changelog entry:

@rwgk
rwgk marked this pull request as ready for review January 14, 2023 02:50
@Skylion007
Skylion007 merged commit e53d58a into pybind:masterJan 14, 2023
@github-actionsgithub-actionsBot added the needs changelog Possibly needs a changelog entry label Jan 14, 2023
@rwgk
rwgk deleted the import_pybind11_tests_traceback branch January 16, 2023 02:01
@rwgkrwgk removed the needs changelog Possibly needs a changelog entry label Jan 16, 2023
@rwgk

rwgk commented Jan 16, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Thanks Aaron!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rwgk@Skylion007