Resolve new flake8 error

[rwgk]

Description

Resolve this new failure:

PR #4461: https://results.pre-commit.ci/run/github/38581626/1674006122.PZIdTNh0SNa60OuNgaDU9w

flake8...................................................................Failed
- hook id: flake8
- exit code: 1
tests/test_modules.py:110:13: B017 assertRaises(Exception): or pytest.raises(Exception) should be considered evil. It can lead to your test passing even if the code being tested is never executed due to a typo. Either assert for a more specific exception (builtin or custom), use assertRaisesRegex, or use the context manager form of assertRaises.
with pytest.raises(Exception):
^

For simplicity & safety, giving up on the idea to future-proof the test (see removed comment).

The danger pointed out by flake8 B017 is real, and currently all Python versions generate a SystemError.

Minor remarks for completeness:

• To reproduce the new flake8 error locally I had to run pre-commit clean
• The bugbear version is not pinned (see below), therefore this failure came as a surprise, unrelated to any changes in pybind11.

Suggested changelog entry:

[henryiii]

It's a flake8-bugbear bump, I expect. You'll need to clear your pre-commit cache locally to see it, as we don't pin bugbear.

[henryiii]

Is there a reason to remove the comment? That seems helpful to both explain why there's an expected exception, as well as if it ever does change, we'd know to just add the new failure there too.

[rwgk]

Is there a reason to remove the comment? That seems helpful to both explain why there's an expected exception, as well as if it ever does change, we'd know to just add the new failure there too.

I wasn't sure, tweak or remove. After seeing your feedback I tweaked now instead of removing. What do you think?

[rwgk]

It's a flake8-bugbear bump, I expect. You'll need to clear your pre-commit cache locally to see it,

Thanks for the hint! Confirmed, after pre-commit clean I'm seeing the error locally. (I never knew about this before.)

as we don't pin bugbear.

Could we pin bugbear? Getting surprised in the middle of something else can be quite distracting.

[Skylion007]

@rwgk Upgrading just becomes a bit annoying since we don't have any autoupdate functionality for pinned additional_dependencies.

[rwgk]

@rwgk Upgrading just becomes a bit annoying since we don't have any autoupdate functionality for pinned additional_dependencies.

Thanks! In that case I think not pinning is fine. Next time I'll be less surprised :-)

Does the changed comment look good to you?

[Skylion007]

Yeah, looks good.

[rwgk]

Thanks!