Uh oh!
There was an error while loading. Please reload this page.
bugfix: delete proper ctors in gil.h - #4490
Merged
Skylion007 merged 1 commit intoFeb 4, 2023
Merged
Conversation
Skylion007force-pushed
the
skylion007/fix-gil-deleted-ctor-bug
branch
from
February 4, 2023 15:43
e9693fd to
a24fea0Comparerwgk
approved these changes
Feb 4, 2023
rwgk
left a comment
Collaborator
There was a problem hiding this comment.
Oh, wow, how did you notice?
(I would have guessed the current code doesn't even compile TBH; or at least clang-tidy will get upset. I'll look more carefully in the future.)
CollaboratorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix#4484 . A copy paste bug resulted in a non-existent ctor being deleted.
Suggested changelog entry: