feat: add pybind11/gil_safe_call_once.h (to fix deadlocks in pybind11/numpy.h) - #4877

Merged

rwgk merged 31 commits into

pybind:masterfrom

rwgk:numpy_h_v2_fix

Oct 12, 2023

Commits on Oct 9, 2023

LazyInitializeAtLeastOnceDestroyNever v1
rwgk
committed
38317c3
Go back to using `union` as originally suggested by jbms@. The trick (also suggested by jbms@) is to add empty ctor + dtor.
rwgk
committed
e7b8c4f
Revert "Go back to using `union` as originally suggested by jbms@. The trick (also suggested by jbms@) is to add empty ctor + dtor."
rwgk
committed
74ac0d9
Remove `#include <stdalign.h>`
rwgk
committed
109a165
Suppress gcc 4.8.5 (CentOS 7) warning.
rwgk
committed
88cec11
Replace comments:
rwgk
committed
1ce2715
Adopt suggestion by @tkoeppe:
rwgk
committed
e7be9c2
Add `PYBIND11_CONSTINIT`, but it does not work for the current use cases:
rwgk
committed
f07b28b
Revert "Add `PYBIND11_CONSTINIT`, but it does not work for the current use cases:"
rwgk
committed
36be645
Reapply "Add `PYBIND11_CONSTINIT`, but it does not work for the current use cases:"
rwgk
committed
7bc16a6
Add Default Member Initializer on `value_storage_` as suggested by @tkoeppe:
rwgk
committed
78f4e93
Fix copy-paste-missed-a-change mishap in commit 88cec1152ab5576db19bab95c484672f06f5989a.
rwgk
committed
6d9441d
Semi-paranoid placement new (based on https://github.com/pybind/pybind11/pull/4877#discussion_r1350573114).
rwgk
committed
a864f21
Move PYBIND11_CONSTINIT to detail/common.h
rwgk
committed
6689b06
Move code to the right places, rename new class and some variables.
rwgk
committed
d965f29
Fix oversight: update tests/extra_python_package/test_files.py
rwgk
committed
398a42c
Get the name right first.
rwgk
committed
ab2cf8e
Use `std::call_once`, `std::atomic`, following a pattern developed by @tkoeppe
rwgk
committed
6d5bdd8
Make the API more self-documenting (and possibly more easily reusable).
rwgk
committed
4c5dd1b
google-clang-tidy IWYU fixes
rwgk
committed
8633c5b

Commits on Oct 10, 2023

Commits on Oct 11, 2023

Additional comment with the conclusion of a discussion under PR #4877.
rwgk
committed
66bbc67
Small comment changes suggested by @tkoeppe.
rwgk
committed
7cd9390

Navigation Menu

Uh oh!

feat: add pybind11/gil_safe_call_once.h (to fix deadlocks in pybind11/numpy.h) - #4877

feat: add pybind11/gil_safe_call_once.h (to fix deadlocks in pybind11/numpy.h)#4877
rwgk merged 31 commits into
pybind:masterfrom
rwgk:numpy_h_v2_fix

Commits on Oct 9, 2023

LazyInitializeAtLeastOnceDestroyNever v1

Go back to using `union` as originally suggested by jbms@. The trick (also suggested by jbms@) is to add empty ctor + dtor.

Revert "Go back to using `union` as originally suggested by jbms@. The trick (also suggested by jbms@) is to add empty ctor + dtor."

Remove `#include <stdalign.h>`

Suppress gcc 4.8.5 (CentOS 7) warning.

Replace comments:

Adopt suggestion by @tkoeppe:

Add `PYBIND11_CONSTINIT`, but it does not work for the current use cases:

Revert "Add `PYBIND11_CONSTINIT`, but it does not work for the current use cases:"

Reapply "Add `PYBIND11_CONSTINIT`, but it does not work for the current use cases:"

Add Default Member Initializer on `value_storage_` as suggested by @tkoeppe:

Fix copy-paste-missed-a-change mishap in commit 88cec1152ab5576db19bab95c484672f06f5989a.

Semi-paranoid placement new (based on https://github.com/pybind/pybind11/pull/4877#discussion_r1350573114).

Move PYBIND11_CONSTINIT to detail/common.h

Move code to the right places, rename new class and some variables.

Fix oversight: update tests/extra_python_package/test_files.py

Get the name right first.

Use `std::call_once`, `std::atomic`, following a pattern developed by @tkoeppe

Make the API more self-documenting (and possibly more easily reusable).

google-clang-tidy IWYU fixes

Commits on Oct 10, 2023

Rewrite comment as suggested by @tkoeppe

Update test_exceptions.cpp and exceptions.rst

Fix oversight in previous commit: add `PYBIND11_CONSTINIT`

Make `get_stored()` non-const for simplicity.

Add comment regarding `KeyboardInterrupt` behavior, based heavily on information provided by @jbms.

Add `assert(PyGILState_Check())` in `gil_scoped_release` ctor (simple & non-simple implementation) as suggested by @EthanSteinberg.

Fix oversight in previous commit (missing include cassert).

Remove use of std::atomic, leaving comments with rationale, why it is not needed.

Rewrite comment re `std:optional` based on deeper reflection (aka 2nd thoughts).

Commits on Oct 11, 2023

Additional comment with the conclusion of a discussion under PR #4877.

Small comment changes suggested by @tkoeppe.