Skip to content

fix: Python 3.13t with GIL - #5139

Merged
henryiii merged 7 commits into
pybind:masterfrom
henryiii:henryiii/ci/313t
May 28, 2024
Merged

fix: Python 3.13t with GIL#5139
henryiii merged 7 commits into
pybind:masterfrom
henryiii:henryiii/ci/313t

Conversation

@henryiii

@henryiiihenryiii commented May 24, 2024•
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

First step toward #5112, just trying to compile against 3.13t.

Suggested changelog entry:

* Compile against Python 3.13t in CI.
* Return ``py::ssize_t`` from ``.ref_count()`` instead of ``int``

@henryiii
ci: try Python 3.13t
15bc5f3
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
fix: support Python 3.13t
c57a840
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
henryiii commented May 24, 2024
View reviewed changes
Comment threadinclude/pybind11/pytypes.h Outdated
@henryiii
fix: patch PyPy
f74d23a
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
tests: one more int cast
0d95846
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
henryiii marked this pull request as ready for review May 25, 2024 03:18
@henryiiihenryiii changed the title ci: try Python 3.13tci: Python 3.13t with GILMay 25, 2024
@henryiii
tests: cleanup
a7c3377
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiiihenryiii mentioned this pull request May 26, 2024
Closed
rwgk
rwgk requested changes May 27, 2024
View reviewed changes
Comment threadtests/test_class.py Outdated
@henryiii
refactor: use named constant in tests for immortal refcounts
884524c
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
rwgk
rwgk approved these changes May 28, 2024
View reviewed changes
Comment threadtests/pybind11_tests.cpp
@henryiiihenryiii changed the title ci: Python 3.13t with GILfix: Python 3.13t with GILMay 28, 2024
@henryiii
docs: move comment about free threaded Python
72a6337
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
henryiii merged commit ae6432b into pybind:masterMay 28, 2024
@henryiii
henryiii deleted the henryiii/ci/313t branch May 28, 2024 13:08
@github-actionsgithub-actionsBot added the needs changelog Possibly needs a changelog entry label May 28, 2024
@henryiiihenryiii mentioned this pull request May 30, 2024
Merged
@henryiiihenryiii removed the needs changelog Possibly needs a changelog entry label Jun 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgkrwgkrwgk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henryiii@rwgk