Uh oh!
There was an error while loading. Please reload this page.
fix: export libc++ exceptions - #5390
Conversation
7e27da3 to
e92dd74Compare8e3fa6e to
549c343Comparerwgk
commented
Oct 8, 2024
This seems to fix an I'm too rushed to look carefully, but that looks good? Did you mean to (also) remove |
cyyever
commented
Oct 10, 2024
@rwgk I have no emscripten env, but I tested on Apple Silicon and it worked. Therefore I removed the MacOS+CPython case. |
rwgk
commented
Oct 10, 2024
We have the Could you please remove |
19d43f4 to
b3c2fb5Comparecyyever
commented
Oct 10, 2024
@rwgk Removed |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
b95db5d to
101a786Compare
rwgk
left a comment
There was a problem hiding this comment.
Thanks a lot for discovering and fixing this bug!
Description
Before this PR, exception translation was still failing on libc++. The failure reason is the visibility of exceptions, which was already discovered in #2999 and reverted by #4324. This PR fixes it by detecting libc++ using the _LIBCPP_EXCEPTION macro and setting PYBIND11_EXPORT_EXCEPTION accordingly. The macro definition is moved below other C++ header inclusion to make sure that _LIBCPP_EXCEPTION is defined.
Suggested changelog entry:
``pybind11::builtin_exception`` is now explicitly exported when linked to libc++.