Uh oh!
There was an error while loading. Please reload this page.
feat: start pybind11v3: Remove all code for PYBIND11_INTERNALS_VERSIONs 4 and 5 - #5530
Merged
Merged
Conversation
rwgk
marked this pull request as ready for review
February 18, 2025 17:18
henryiii
approved these changes
Feb 19, 2025
rwgk
commented
Feb 19, 2025
CollaboratorAuthor
Thanks @henryiii! |
This was referenced Feb 19, 2025
PYBIND11_INTERNALS_VERSIONs 4 and 5PYBIND11_INTERNALS_VERSIONs 4 and 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump pybind11 version to v3.0.0dev1 and remove all code for
PYBIND11_INTERNALS_VERSIONs4and5.This PR is meant to simplify merging the smart_holder branch: A very large number of
#ifdef PYBIND11_INTERNALS_VERSION > 6(or similar) can be removed.See also:
Suggested changelog entry: