Skip to content

Fix GraalPy version parsing on dev builds - #5609

Merged
rwgk merged 2 commits into
pybind:masterfrom
msimacek:msimacek/graalpy
Apr 9, 2025
Merged

Fix GraalPy version parsing on dev builds#5609
rwgk merged 2 commits into
pybind:masterfrom
msimacek:msimacek/graalpy

Conversation

@msimacek

Copy link
Copy Markdown
Contributor

I want to run pybind11 tests in our CI and dev builds have -dev suffix in the version.
I also unskipped a test that was previously broken due to the capsule name comparisons, but pybind11 has since moved away from doing those comparisons altogether.

@rwgk

rwgk commented Apr 9, 2025

Copy link
Copy Markdown
Collaborator

but pybind11 has since moved away from doing those comparisons altogether.

Do you think that was #5580?

@msimacek

Copy link
Copy Markdown
ContributorAuthor

Yes

rwgk
rwgk approved these changes Apr 9, 2025
@rwgk
rwgk merged commit 708ce4d into pybind:masterApr 9, 2025
@github-actionsgithub-actionsBot added the needs changelog Possibly needs a changelog entry label Apr 9, 2025
@rwgkrwgk removed the needs changelog Possibly needs a changelog entry label Apr 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@msimacek@rwgk