Uh oh!
There was an error while loading. Please reload this page.
chore: rename generic slots variable - #5793
Conversation
fdb6195 to
1e2acd5CompareUh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com> style: pre-commit fixes
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
e61877b to
ec27916Comparehenryiii
commented
Aug 13, 2025
Getting this on 3.13t pretty often: |
rwgk
commented
Aug 14, 2025
Yeah ... it used to be rare until about a month ago, but suddenly this particular test CI / 🐍 (macos-13, 3.13t, -DCMAKE_CXX_STANDARD=11) started failing very often. I don't know why, but I believe almost certainly this is unrelated to changes in pybind11. Maybe there was a Python 3.13 patch release? Or the macOS runners had some change? If nobody has time to drill down (I don't), maybe we should just disable those tests under macOS with free-threading? |
rwgk
commented
Aug 14, 2025
It wasn't quite a month ago, this was the first time I noticed, July 28, 2025: |
Osyotr
commented
Aug 15, 2025
This is probably not enough to fix the original problem. |
rwgk
commented
Aug 16, 2025
That's in the cpython sources. There is nothing we can do about that, but I'd vote for merging @Henriii's changes, they make the naming better in general. |
henryiii
commented
Aug 20, 2025
You tagged the wrong henryiii, FYI :) |
Uh oh!
There was an error while loading. Please reload this page.
Description
Fix#5788. Make it a bit easier to interface with Qt code. Qt's terrible macro names strike again.
Suggested changelog entry:
slots(reads better)📚 Documentation preview 📚: https://pybind11--5793.org.readthedocs.build/