Skip to content

ESP-NOW documentation and updating Coap documentation after esp-idf 4.1 update - #292

Closed
geza-pycom wants to merge 9 commits into
pycom:development-publishfrom
geza-pycom:Coap-idf4
Closed

ESP-NOW documentation and updating Coap documentation after esp-idf 4.1 update#292
geza-pycom wants to merge 9 commits into
pycom:development-publishfrom
geza-pycom:Coap-idf4

Conversation

@geza-pycom

@geza-pycomgeza-pycom commented Jul 1, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@peter-pycom
peter-pycom self-requested a review January 21, 2021 11:27
peter-pycom
peter-pycom suggested changes Jan 21, 2021
View reviewed changes
Comment threadcontent/firmwareapi/pycom/network/espnow.md Outdated
Comment threadcontent/firmwareapi/pycom/network/espnow.md Outdated
Comment threadcontent/firmwareapi/pycom/network/coap.md
Comment threadcontent/firmwareapi/pycom/network/espnow.md Outdated
Comment threadcontent/firmwareapi/pycom/network/coap.md Outdated
Comment threadcontent/firmwareapi/pycom/network/coap.md Outdated
Comment threadcontent/firmwareapi/pycom/network/coap.md Outdated
Comment threadcontent/firmwareapi/pycom/network/coap.md Outdated
Comment threadcontent/firmwareapi/pycom/network/coap.md Outdated
Comment threadcontent/firmwareapi/pycom/network/coap.md Outdated
geza-pycom
geza-pycom commented Jan 22, 2021
View reviewed changes

@geza-pycomgeza-pycom left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments.

@geza-pycom

geza-pycom commented Jan 22, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@peter-pycom : just heads up that please do not merge this once we have discussed all the comments, I am not sure whether this is the correct branch to merge these updates.

@geza-pycomgeza-pycom changed the title Updating Coap documentation after esp-idf 4 updateESP-NOW documentation and updating Coap documentation after esp-idf 4.1 updateJan 22, 2021
peter-pycom
peter-pycom previously approved these changes Feb 10, 2021
View reviewed changes

@peter-pycompeter-pycom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. It's much clearer to me now. Thanks.

peter-pycom
peter-pycom suggested changes Feb 10, 2021
View reviewed changes
Comment threadcontent/firmwareapi/pycom/network/coap.md
* `resource` is the new resource which has been created

#### Coap.new_client_session(destination, port=5683, protocol=UDP)
#### Coap.new_client_session(address, *, port=5683, psk=None, identity=None)

@peter-pycompeter-pycomFeb 10, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new_client_session() has lost the protocol param, but remove_client_session() still has it. intentional?

@geza-pycomgeza-pycomFeb 10, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is.
When you call new_client_session() the Protocol is figured out based on the PSK and Identity parameters.
When you cal remove_client_session() it may happen that you have 2 Clients connected to the same Port, but one is using UDP the other is DTLS.

@peter-pycom

peter-pycom commented Mar 3, 2021

Copy link
Copy Markdown
Contributor

I think you guys agreed on a branch for this, right? Can you update the PR?

@geza-pycomgeza-pycom mentioned this pull request Mar 3, 2021
Open
@geza-pycom

geza-pycom commented Mar 3, 2021

Copy link
Copy Markdown
ContributorAuthor

New request opened towards correct branch: #387

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@peter-pycompeter-pycompeter-pycom requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@geza-pycom@peter-pycom