Uh oh!
There was an error while loading. Please reload this page.
CI: Automatic PR labelling is back - #10201
Conversation
This reverts commit ce1af97.
There was some duplication here as `**` would capture `*` etc
Here's a script for your convenience showing each glob and the files it matches. Just CTRL+F for "no matches" frompathlibimportPathimportyamlCODEBASE=Path(".")
CONFIG_PATH=CODEBASE/".github/labeler.yml"CONFIG=yaml.safe_load(CONFIG_PATH.read_text())
delCONFIG["needs triage"]
defmain():
fortopic, label_objinCONFIG.items():
globs=label_obj[0]["changed-files"][0]["any-glob-to-any-file"]
print(f"## {topic}")
forglobinglobs:
print(f"- glob: {glob}")
matches=list(CODEBASE.glob(glob))
forminmatches:
print(f" - {m}")
iflen(matches) ==0:
print(" - no matches")
print("\n")
if__name__=="__main__":
main()output |
VeckoTheGecko
commented
Apr 7, 2025
pinging @TomNicholas since you submitted the prior issues/PRs on this topic. Feel free to review if you have a moment :) |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
max-sixty
commented
Apr 8, 2025
this looks good! I would recommend we slim down the categories a bit — easy to add more if we need, harder to prune I think the standard could be "would someone reasonable want to subscribe to one of the labels", for example I would like to immediately look at any issues with Rolling... |
Uh oh!
There was an error while loading. Please reload this page.
max-sixty
commented
Apr 8, 2025
lgtm — any feedback from anyone before merging? |
TomNicholas
left a comment
There was a problem hiding this comment.
This is great - I've missed this bot - thanks @VeckoTheGecko !
* Revert "Remove PR labeler bot (pydata#8525)" This reverts commit ce1af97. * Remove redundant globs There was some duplication here as `**` would capture `*` etc * Update actions/labeler to v5 * Label all PRs as "needs triage" * Try my best to update config to match current structure * patch needs triage regex * run pre-commit * Update labeler.yml to match current project structure * pr feedback
* main: (76 commits) Update how-to-add-new-backend.rst (#10240) Support extension array indexes (#9671) Switch documentation to pydata-sphinx-theme (#8708) Bump codecov/codecov-action from 5.4.0 to 5.4.2 in the actions group (#10239) Fix mypy, min-versions CI, xfail Zarr tests (#10255) Remove `test_dask_layers_and_dependencies` (#10242) Fix: Docs generation create temporary files that are not cleaned up. (#10238) opendap / dap4 support for pydap backend (#10182) Add RangeIndex (#10076) Fix mypy (#10232) Fix doctests (#10230) Fix broken Sphinx Roles (#10225) `DatasetView.map` fix `keep_attrs` (#10219) Add datatree repr asv (#10214) CI: Automatic PR labelling is back (#10201) Fixes dimension order in `xarray.Dataset.to_stacked_array` (#10205) Fix references to core classes in docs (#10207) Update pre-commit hooks (#10208) add `scipy-stubs` as extra `[types]` dependency (#10202) Fix sparse dask repr test (#10200) ...
* main: (76 commits) Update how-to-add-new-backend.rst (pydata#10240) Support extension array indexes (pydata#9671) Switch documentation to pydata-sphinx-theme (pydata#8708) Bump codecov/codecov-action from 5.4.0 to 5.4.2 in the actions group (pydata#10239) Fix mypy, min-versions CI, xfail Zarr tests (pydata#10255) Remove `test_dask_layers_and_dependencies` (pydata#10242) Fix: Docs generation create temporary files that are not cleaned up. (pydata#10238) opendap / dap4 support for pydap backend (pydata#10182) Add RangeIndex (pydata#10076) Fix mypy (pydata#10232) Fix doctests (pydata#10230) Fix broken Sphinx Roles (pydata#10225) `DatasetView.map` fix `keep_attrs` (pydata#10219) Add datatree repr asv (pydata#10214) CI: Automatic PR labelling is back (pydata#10201) Fixes dimension order in `xarray.Dataset.to_stacked_array` (pydata#10205) Fix references to core classes in docs (pydata#10207) Update pre-commit hooks (pydata#10208) add `scipy-stubs` as extra `[types]` dependency (pydata#10202) Fix sparse dask repr test (pydata#10200) ...
Automatic PR labelling was added in #6912, then removed in [#8524, #8525] due to an archived dependency.
This PR fixes#8524. It:
needs triage.github/labeler.ymlchanged-files: any-glob-to-any-file:to each glob.Please validate the
labeler.ymlconfig is correct and matches current project structure, or modify as you otherwise see fit.See open PR on my fork (VeckoTheGecko#3) for an example.
(ps, can someone update the body of GH10198 to point to point to GH9524 not GH8524? Kinda funny that a typo led to this PR 😂)