Uh oh!
There was an error while loading. Please reload this page.
Fix convert calendar on non-temporal data in datasets - #10268
Merged
Conversation
spencerkclark
approved these changes
Apr 29, 2025
spencerkclark
left a comment
Member
There was a problem hiding this comment.
Thanks @aulemahal—this makes more sense to me too!
dcherian
approved these changes
Apr 29, 2025
dcherian added a commit
to dcherian/xarray
that referenced
this pull request
Apr 29, 2025
* main: Fix convert calendar on non-temporal data in datasets (pydata#10268) BinGrouper: reduce indirection (pydata#10270) Fix reduction by subset of grouper dimensions (pydata#10258) Shorten text repr for ``DataTree`` (pydata#10139) Fix benchmarks runners (pydata#10265) Fix infinite recursion when calling `np.fix` (pydata#10248) BinGrouper: Support setting labels when provided with IntervalIndex (pydata#10259) Avoid stacking when grouping by chunked array (pydata#10254) Improve alignment checks (pydata#10251) Update how-to-add-new-backend.rst (pydata#10240) Support extension array indexes (pydata#9671) Switch documentation to pydata-sphinx-theme (pydata#8708) Bump codecov/codecov-action from 5.4.0 to 5.4.2 in the actions group (pydata#10239)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convert_calendaradds atimedimension to all variables #10266whats-new.rstWhen calling
convert_calendaron dataset with non-temporal variable (notimedimension), thetimedimension was added. This is because the function was usingwhere(time.notnull(), drop=True)to drop the time elements of the source that did not map to a valid time in the target calendar.Given that
timeis always 1D and always loaded (no dask), usingsel(time=time.notnull())fixes the bug, and, in fact, makes more sense to me. (I don't remember why I didn't use that in my first version of the method...)I added a minimal test that detects the bug raised in the issue.