Uh oh!
There was an error while loading. Please reload this page.
Enforce ruff/flake8-simplify rules (SIM) - #10480
Merged
Merged
Conversation
4 tasks
max-sixty
approved these changes
Jul 1, 2025
max-sixty
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! (though the previous one lgtm too...)
any feedback from others?
Uh oh!
There was an error while loading. Please reload this page.
SIM102 Use a single `if` statement instead of nested `if` statements
SIM113 Use `enumerate()` for index variable in `for` loop
SIM114 Combine `if` branches using logical `or` operator
SIM201 Use `... != ...` instead of `not ... == ..."`
SIM905 Consider using a list literal instead of `str.split`
SIM910 Use `.get(...)` instead of `.get(..., None)`
Co-authored-by: Illviljan <14371165+Illviljan@users.noreply.github.com>
SIM102 Use a single `if` statement instead of nested `if` statements
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmitting #10462, this time ignoring ruff rule SIM118.
Please review carefully each commit/rule, I am happy to ignore any rule you don't find useful. For example, I'm not certain whether SIM102 results in more readable or more efficient code (9643fdd).
whats-new.rstapi.rst