Uh oh!
There was an error while loading. Please reload this page.
Remove outdated code related to compatibility with netcdftime - #3450
Merged
Conversation
dcherian
approved these changes
Oct 26, 2019
dcherian
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks @spencerkclark
dcherian
commented
Oct 29, 2019
Contributor
Thanks @spencerkclark |
dcherian added a commit
to dcherian/xarray
that referenced
this pull request
Oct 29, 2019
* upstream/master: upgrade black verison to 19.10b0 (pydata#3456) Remove outdated code related to compatibility with netcdftime (pydata#3450) Remove deprecated behavior from dataset.drop docstring (pydata#3451) jupyterlab dark theme (pydata#3443) Drop groups associated with nans in group variable (pydata#3406) Allow ellipsis (...) in transpose (pydata#3421) Another groupby.reduce bugfix. (pydata#3403) add icomoon license (pydata#3448) change ALL_DIMS to equal ellipsis (pydata#3418) Escaping dtypes (pydata#3444) Html repr (pydata#3425)
dcherian added a commit
to dcherian/xarray
that referenced
this pull request
Oct 29, 2019
* upstream/master: upgrade black verison to 19.10b0 (pydata#3456) Remove outdated code related to compatibility with netcdftime (pydata#3450)
dcherian added a commit
to dcherian/xarray
that referenced
this pull request
Oct 30, 2019
commit 08f7f74 Merge: 53c0f4e278d2e6 Author: dcherian <deepak@cherian.net> Date: Tue Oct 29 09:36:58 2019 -0600 Merge remote-tracking branch 'upstream/master' into fix/dask-computes * upstream/master: upgrade black verison to 19.10b0 (pydata#3456) Remove outdated code related to compatibility with netcdftime (pydata#3450) commit 53c0f4e Author: dcherian <deepak@cherian.net> Date: Tue Oct 29 09:25:27 2019 -0600 Add identity check to lazy_array_equiv commit 5e742e4 Author: dcherian <deepak@cherian.net> Date: Tue Oct 29 09:22:15 2019 -0600 update whats new commit ee0d422 Merge: e99148e74ca69a Author: dcherian <deepak@cherian.net> Date: Tue Oct 29 09:18:38 2019 -0600 Merge remote-tracking branch 'upstream/master' into fix/dask-computes * upstream/master: Remove deprecated behavior from dataset.drop docstring (pydata#3451) jupyterlab dark theme (pydata#3443) Drop groups associated with nans in group variable (pydata#3406) Allow ellipsis (...) in transpose (pydata#3421) Another groupby.reduce bugfix. (pydata#3403) add icomoon license (pydata#3448) commit e99148e Author: dcherian <deepak@cherian.net> Date: Tue Oct 29 09:17:58 2019 -0600 add concat test commit 4a66e7c Author: dcherian <deepak@cherian.net> Date: Mon Oct 28 10:19:32 2019 -0600 review suggestions. commit 8739ddd Author: dcherian <deepak@cherian.net> Date: Mon Oct 28 08:32:15 2019 -0600 better docstring commit e84cc97 Author: dcherian <deepak@cherian.net> Date: Sun Oct 27 20:22:13 2019 -0600 Optimize dask array equality checks. Dask arrays with the same graph have the same name. We can use this to quickly compare dask-backed variables without computing. Fixespydata#3068 and pydata#3311
dcherian added a commit
to dcherian/xarray
that referenced
this pull request
Oct 30, 2019
commit bc39877 Merge: 507b1f6278d2e6 Author: dcherian <deepak@cherian.net> Date: Tue Oct 29 09:36:30 2019 -0600 Merge remote-tracking branch 'upstream/master' into dask-tokenize * upstream/master: upgrade black verison to 19.10b0 (pydata#3456) Remove outdated code related to compatibility with netcdftime (pydata#3450) Remove deprecated behavior from dataset.drop docstring (pydata#3451) jupyterlab dark theme (pydata#3443) Drop groups associated with nans in group variable (pydata#3406) Allow ellipsis (...) in transpose (pydata#3421) Another groupby.reduce bugfix. (pydata#3403) add icomoon license (pydata#3448) change ALL_DIMS to equal ellipsis (pydata#3418) Escaping dtypes (pydata#3444) Html repr (pydata#3425) commit 507b1f6 Author: dcherian <deepak@cherian.net> Date: Tue Oct 29 09:34:47 2019 -0600 Fix window test commit 4ab6a66 Author: dcherian <deepak@cherian.net> Date: Thu Oct 24 14:30:57 2019 -0600 Implement __dask_tokenize__
dcherian added a commit
to dcherian/xarray
that referenced
this pull request
Nov 2, 2019
commit 0711eb0 Author: dcherian <deepak@cherian.net> Date: Thu Oct 31 21:18:58 2019 -0600 bugfix. commit 4ee2963 Author: Deepak Cherian <dcherian@users.noreply.github.com> Date: Thu Oct 31 11:27:05 2019 -0600 pep8 commit 6e4c11f Merge: 08f7f7453c5199 Author: Deepak Cherian <dcherian@users.noreply.github.com> Date: Thu Oct 31 11:25:12 2019 -0600 Merge branch 'master' into fix/dask-computes commit 08f7f74 Merge: 53c0f4e278d2e6 Author: dcherian <deepak@cherian.net> Date: Tue Oct 29 09:36:58 2019 -0600 Merge remote-tracking branch 'upstream/master' into fix/dask-computes * upstream/master: upgrade black verison to 19.10b0 (pydata#3456) Remove outdated code related to compatibility with netcdftime (pydata#3450) commit 53c0f4e Author: dcherian <deepak@cherian.net> Date: Tue Oct 29 09:25:27 2019 -0600 Add identity check to lazy_array_equiv commit 5e742e4 Author: dcherian <deepak@cherian.net> Date: Tue Oct 29 09:22:15 2019 -0600 update whats new commit ee0d422 Merge: e99148e74ca69a Author: dcherian <deepak@cherian.net> Date: Tue Oct 29 09:18:38 2019 -0600 Merge remote-tracking branch 'upstream/master' into fix/dask-computes * upstream/master: Remove deprecated behavior from dataset.drop docstring (pydata#3451) jupyterlab dark theme (pydata#3443) Drop groups associated with nans in group variable (pydata#3406) Allow ellipsis (...) in transpose (pydata#3421) Another groupby.reduce bugfix. (pydata#3403) add icomoon license (pydata#3448) commit e99148e Author: dcherian <deepak@cherian.net> Date: Tue Oct 29 09:17:58 2019 -0600 add concat test commit 4a66e7c Author: dcherian <deepak@cherian.net> Date: Mon Oct 28 10:19:32 2019 -0600 review suggestions. commit 8739ddd Author: dcherian <deepak@cherian.net> Date: Mon Oct 28 08:32:15 2019 -0600 better docstring commit e84cc97 Author: dcherian <deepak@cherian.net> Date: Sun Oct 27 20:22:13 2019 -0600 Optimize dask array equality checks. Dask arrays with the same graph have the same name. We can use this to quickly compare dask-backed variables without computing. Fixespydata#3068 and pydata#3311
dcherian added a commit
to dcherian/xarray
that referenced
this pull request
Nov 4, 2019
* upstream/master: __dask_tokenize__ (pydata#3446) Type check sentinel values (pydata#3472) Fix typo in docstring (pydata#3474) fix test suite warnings re `drop` (pydata#3460) Fix integrate docs (pydata#3469) Fix leap year condition in monthly means example (pydata#3464) Hypothesis tests for roundtrip to & from pandas (pydata#3285) unpin cftime (pydata#3463) Cleanup whatsnew (pydata#3462) enable xr.ALL_DIMS in xr.dot (pydata#3424) Merge stable into master (pydata#3457) upgrade black verison to 19.10b0 (pydata#3456) Remove outdated code related to compatibility with netcdftime (pydata#3450) Remove deprecated behavior from dataset.drop docstring (pydata#3451) jupyterlab dark theme (pydata#3443) Drop groups associated with nans in group variable (pydata#3406) Allow ellipsis (...) in transpose (pydata#3421) Another groupby.reduce bugfix. (pydata#3403) add icomoon license (pydata#3448)
dcherian added a commit
to dcherian/xarray
that referenced
this pull request
Nov 8, 2019
* upstream/master: (27 commits) drop_vars; deprecate drop for variables (pydata#3475) uamiv test using only raw uamiv variables (pydata#3485) Optimize dask array equality checks. (pydata#3453) Propagate indexes in DataArray binary operations. (pydata#3481) python 3.8 tests (pydata#3477) __dask_tokenize__ (pydata#3446) Type check sentinel values (pydata#3472) Fix typo in docstring (pydata#3474) fix test suite warnings re `drop` (pydata#3460) Fix integrate docs (pydata#3469) Fix leap year condition in monthly means example (pydata#3464) Hypothesis tests for roundtrip to & from pandas (pydata#3285) unpin cftime (pydata#3463) Cleanup whatsnew (pydata#3462) enable xr.ALL_DIMS in xr.dot (pydata#3424) Merge stable into master (pydata#3457) upgrade black verison to 19.10b0 (pydata#3456) Remove outdated code related to compatibility with netcdftime (pydata#3450) Remove deprecated behavior from dataset.drop docstring (pydata#3451) jupyterlab dark theme (pydata#3443) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #3431 (comment), this removes outdated code leftover from the netcdftime -> cftime transition. Currently the minimum version of netCDF4 that xarray tests against is 1.4, which does not include netcdftime, and instead specifies cftime as a required dependency.
black . && mypy . && flake8whats-new.rstfor all changes andapi.rstfor new API