Skip to content

New coords to existing dim (doc) - #3958

Merged
dcherian merged 8 commits into
pydata:masterfrom
EtienneCmb:master
Apr 10, 2020
Merged

New coords to existing dim (doc)#3958
dcherian merged 8 commits into
pydata:masterfrom
EtienneCmb:master

Conversation

@EtienneCmb

@EtienneCmbEtienneCmb commented Apr 9, 2020•
edited by keewis
Loading

Copy link
Copy Markdown
Contributor

max-sixty
max-sixty approved these changes Apr 10, 2020
View reviewed changes

@max-sixtymax-sixty left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EtienneCmb !
Would you mind adding a short line to whatsnew with attribution for you?

Comment threadxarray/core/common.py Outdated
@EtienneCmb@max-sixty
Update xarray/core/common.py
73aff23
Co-Authored-By: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
@pep8speaks

pep8speaks commented Apr 10, 2020•
edited
Loading

Copy link
Copy Markdown

Hello @EtienneCmb! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-04-10 12:15:42 UTC

keewis
keewis reviewed Apr 10, 2020
View reviewed changes

@keewiskeewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @EtienneCmb

A few comments, but otherwise this looks good to me.

Comment threadxarray/core/common.py Outdated
Comment threadxarray/core/common.py Outdated
Comment threadxarray/core/common.py Outdated
EtienneCmband others added 3 commits April 10, 2020 14:14
@EtienneCmb@keewis
Update xarray/core/common.py
4f3f23e
add space
Co-Authored-By: keewis <keewis@users.noreply.github.com>
@EtienneCmb@keewis
Update xarray/core/common.py
c57b0ef
Co-Authored-By: keewis <keewis@users.noreply.github.com>
@EtienneCmb@keewis
Update xarray/core/common.py
a091515
Co-Authored-By: keewis <keewis@users.noreply.github.com>
@EtienneCmb

EtienneCmb commented Apr 10, 2020

Copy link
Copy Markdown
ContributorAuthor

@keewis thanks for the suggestions

@dcherian

dcherian commented Apr 10, 2020

Copy link
Copy Markdown
Contributor

Thanks @EtienneCmb

@dcherian
dcherian merged commit 7a037d5 into pydata:masterApr 10, 2020
@EtienneCmb

EtienneCmb commented Apr 10, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@dcherian@keewis The final line is not properly formatted in the latest version of the doc. I think there's the need of an empty line before the >>>

@keewis

keewis commented Apr 10, 2020

Copy link
Copy Markdown
Collaborator

thanks for checking, @EtienneCmb. I don't think the _ matters, this mostly happens because of a missing newline before the doctest line (the one that starts with >>>). Would you like to open a new PR fixing that?

@EtienneCmbEtienneCmb mentioned this pull request Apr 10, 2020
Merged
2 tasks
dcherian added a commit to dcherian/xarray that referenced this pull request May 1, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into map-blocks-schema
085ce9a
* upstream/master: (39 commits)
Pint support for DataArray (pydata#3643)
Apply blackdoc to the documentation (pydata#4012)
ensure Variable._repr_html_ works (pydata#3973)
Fix handling of abbreviated units like msec (pydata#3998)
full_like: error on non-scalar fill_value (pydata#3979)
Fix some code quality and bug-risk issues (pydata#3999)
DOC: add pandas.DataFrame.to_xarray (pydata#3994)
Better chunking error messages for zarr backend (pydata#3983)
Silence sphinx warnings (pydata#3990)
Fix distributed tests on upstream-dev (pydata#3989)
Add multi-dimensional extrapolation example and mention different behavior of kwargs in interp (pydata#3956)
keep attrs in interpolate_na (pydata#3970)
actually use preformatted text in the details summary (pydata#3978)
facetgrid: Ensure that colormap params are only determined once. (pydata#3915)
RasterioDeprecationWarning (pydata#3964)
Empty line missing for DataArray.assign_coords doc (pydata#3963)
New coords to existing dim (doc) (pydata#3958)
implement a more threadsafe call to colorbar (pydata#3944)
Fix wrong order of coordinate converted from pd.series with MultiIndex (pydata#3953)
Updated list of core developers (pydata#3943)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keewiskeewiskeewis left review comments
@max-sixtymax-sixtymax-sixty approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Doc improvement for DataArray.assign_coords

5 participants

@EtienneCmb@pep8speaks@dcherian@keewis@max-sixty