Skip to content

silence the dask dataframe upstream-dev errors - #4757

Merged
andersy005 merged 3 commits into
pydata:masterfrom
keewis:fix-dask-dataframe-tests
Jan 4, 2021
Merged

silence the dask dataframe upstream-dev errors#4757
andersy005 merged 3 commits into
pydata:masterfrom
keewis:fix-dask-dataframe-tests

Conversation

@keewis

@keewiskeewis commented Jan 3, 2021

Copy link
Copy Markdown
Collaborator

Some of the to_dask_dataframe tests fail on the upstream-dev CI because the behavior of pandas.DataFrame changed (see pandas-dev/pandas#38645). For now we can silence these by computing all dask arrays we pass to pandas.DataFrame.

max-sixty
max-sixty reviewed Jan 3, 2021
View reviewed changes
Comment threadxarray/tests/test_dask.py Outdated
@max-sixty

max-sixty commented Jan 3, 2021

Copy link
Copy Markdown
Collaborator

Thanks @keewis

How should we think about changing the test code vs xfailing?

IIUC the current test code should work, but doesn't because of the pandas issue. Would we expect to revert this after pandas fixes its issue?

keewisand others added 2 commits January 3, 2021 22:39
@keewis@max-sixty
Update xarray/tests/test_dask.py
514d04f
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
@keewis
create the dask array immediately before passing it to Dataset
e762e89
@keewis

keewis commented Jan 3, 2021

Copy link
Copy Markdown
CollaboratorAuthor

How should we think about changing the test code vs xfailing?

that's a good point. I'm really not sure: in this case we don't change the behavior of the test, but in general it would probably be better to xfail.

@dcherian

dcherian commented Jan 3, 2021

Copy link
Copy Markdown
Contributor

It's a bug in constructing an expected dataframe. Seems OK to change it and not revert once pandas fixes its behaviour.

max-sixty
max-sixty approved these changes Jan 4, 2021
View reviewed changes

@max-sixtymax-sixty left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case we don't change the behavior of the test

I see, SGTM

@andersy005
andersy005 merged commit 8731acc into pydata:masterJan 4, 2021
@keewis
keewis deleted the fix-dask-dataframe-tests branch January 4, 2021 15:23
@keewiskeewis mentioned this pull request Mar 17, 2021
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcheriandcheriandcherian approved these changes
@max-sixtymax-sixtymax-sixty approved these changes
@andersy005andersy005andersy005 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

⚠️ Nightly upstream-dev CI failed ⚠️

4 participants

@keewis@max-sixty@dcherian@andersy005