Skip to content

Add DataArrayCoarsen.reduce and DatasetCoarsen.reduce methods - #4939

Merged
spencerkclark merged 11 commits into
pydata:masterfrom
spencerkclark:coarsen-reduce
Feb 23, 2021
Merged

Add DataArrayCoarsen.reduce and DatasetCoarsen.reduce methods#4939
spencerkclark merged 11 commits into
pydata:masterfrom
spencerkclark:coarsen-reduce

Conversation

@spencerkclark

@spencerkclarkspencerkclark commented Feb 21, 2021•
edited
Loading

Copy link
Copy Markdown
Member

As suggested by @dcherian, this was quite similar to rolling; it was useful in particular to follow how the tests were implemented there.

mathause
mathause reviewed Feb 23, 2021
View reviewed changes

@mathausemathause left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, missing the doc entries.

Comment threadxarray/core/rolling.py
return wrapped_func

def reduce(self, func: Callable, **kwargs):
"""Reduce the items in this group by applying `func` along some

@mathausemathauseFeb 23, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Reducetheitemsinthisgroupbyapplying`func`alongsome
"""Reducetheitemsinthisgroupbyapplying``func``alongsome

I think docstrings are in rst format?

@spencerkclarkspencerkclarkFeb 23, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back and forth on this, and eventually opted to keep things as they were. This is consistent with the other docstrings for rolling and coarsening objects. I don't have a strong opinion though.

@mathausemathauseFeb 23, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One backtick seems to render as italics and two as code block. In text form I also like the single backticks more. I am fine to leave as is.

https://xray--4939.org.readthedocs.build/en/4939/generated/xarray.core.rolling.DataArrayCoarsen.reduce.html#xarray.core.rolling.DataArrayCoarsen.reduce

https://xray--4939.org.readthedocs.build/en/4939/generated/xarray.core.weighted.DataArrayWeighted.mean.html

Comment threadxarray/tests/test_dataarray.py
Comment threadxarray/tests/test_dataarray.py Outdated
Comment threadxarray/tests/test_dataarray.py Outdated
Comment threadxarray/core/rolling.py Outdated
@spencerkclark

spencerkclark commented Feb 23, 2021

Copy link
Copy Markdown
MemberAuthor

Thanks for the review @mathause! Let me know if things look good from your end now.

@pep8speaks

pep8speaks commented Feb 23, 2021•
edited
Loading

Copy link
Copy Markdown

Hello @spencerkclark! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-23 15:08:14 UTC

mathause
mathause reviewed Feb 23, 2021
View reviewed changes
Comment threadxarray/core/rolling.py Outdated
spencerkclarkand others added 2 commits February 23, 2021 09:36
@spencerkclark@mathause
Update xarray/core/rolling.py
b977701
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
@spencerkclark
Fix what's new link
7015524
mathause
mathause approved these changes Feb 23, 2021
View reviewed changes

@mathausemathause left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment threadxarray/core/rolling.py
return wrapped_func

def reduce(self, func: Callable, **kwargs):
"""Reduce the items in this group by applying `func` along some

@mathausemathauseFeb 23, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One backtick seems to render as italics and two as code block. In text form I also like the single backticks more. I am fine to leave as is.

https://xray--4939.org.readthedocs.build/en/4939/generated/xarray.core.rolling.DataArrayCoarsen.reduce.html#xarray.core.rolling.DataArrayCoarsen.reduce

https://xray--4939.org.readthedocs.build/en/4939/generated/xarray.core.weighted.DataArrayWeighted.mean.html

Comment threadxarray/core/rolling.py Outdated
Comment threadxarray/core/rolling.py Outdated
spencerkclarkand others added 2 commits February 23, 2021 10:07
@spencerkclark@mathause
Update xarray/core/rolling.py
0306746
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
@spencerkclark@mathause
Update xarray/core/rolling.py
8416383
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
@spencerkclark
spencerkclark merged commit f554d0a into pydata:masterFeb 23, 2021
@spencerkclark
spencerkclark deleted the coarsen-reduce branch February 23, 2021 16:01
@spencerkclarkspencerkclark mentioned this pull request Feb 23, 2021
Merged
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 8, 2021
@dcherian
Merge remote-tracking branch 'upstream/master' into fix/4107
3f04332
* upstream/master: (46 commits)
pin netCDF4=1.5.3 in min-all-deps (pydata#4982)
fix matplotlib errors for single level discrete colormaps (pydata#4256)
Adapt exception handling in CFTimeIndex.__sub__ and __rsub__ (pydata#5006)
Update options.py (pydata#5000)
Adjust tests to use updated pandas syntax for offsets (pydata#4537)
add a combine_attrs parameter to Dataset.merge (pydata#4895)
Support for dask.graph_manipulation (pydata#4965)
raise on passing axis to Dataset.reduce methods (pydata#4940)
Whatsnew for 0.17.1 (pydata#4963)
Refinements to how-to-release (pydata#4964)
DOC: add example for reindex (pydata#4956)
DOC: rm np import (pydata#4949)
Add 0.17.0 release notes (pydata#4953)
document update as inplace (pydata#4932)
bump the dependencies (pydata#4942)
Upstream CI: limit runtime (pydata#4946)
typing for numpy 1.20 (pydata#4878)
Use definition of DTypeLike from Numpy if found (pydata#4941)
autoupdate mypy (pydata#4943)
Add DataArrayCoarsen.reduce and DatasetCoarsen.reduce methods (pydata#4939)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcheriandcheriandcherian approved these changes
@mathausemathausemathause approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DataArrayCoarsen does not have a map or reduce function

4 participants

@spencerkclark@pep8speaks@dcherian@mathause