Uh oh!
There was an error while loading. Please reload this page.
combine keep_attrs and combine_attrs in apply_ufunc - #5041
Conversation
keewis
commented
Mar 25, 2021
it seems |
max-sixty
left a comment
There was a problem hiding this comment.
No strong view on how we combine on the coords. Though is there any reason to wait on merging this? The tests are great!
Uh oh!
There was an error while loading. Please reload this page.
dcherian
commented
Apr 19, 2021
👍 on this. can fix later though... |
keewis
commented
Apr 19, 2021
|
keewis
commented
May 5, 2021
this is ready, too. Not sure if we should merge before the release, though. |
max-sixty
commented
May 5, 2021
As good a time as any! But as ever your call on whether we can be sufficiently confident |
keewis
left a comment
There was a problem hiding this comment.
considering that we originally planned to release tomorrow (?) I'd say let's wait and include this in the next release. I just went through the code and found a few issues which need more thought (I think?)
Uh oh!
There was an error while loading. Please reload this page.
keewis
commented
May 8, 2021
not sure if I got all of the issues I thought I noticed, but I think this should be ready |
max-sixty
left a comment
There was a problem hiding this comment.
Tests look good!
(Whatsnew needs switching versions FYI)
keewis
commented
May 8, 2021
thanks, I completely missed that |
dcherian
commented
May 13, 2021
Thanks @keewis. I found the Thanks! |
* upstream/master: combine keep_attrs and combine_attrs in apply_ufunc (pydata#5041) Explained what a deprecation cycle is (pydata#5289) Code cleanup (pydata#5234) FacetGrid docstrings (pydata#5293) Add whats new for dataset interpolation with non-numerics (pydata#5297) Allow dataset interpolation with different datatypes (pydata#5008) Flexible indexes: add Index base class and xindexes properties (pydata#5102) pre-commit: autoupdate hook versions (pydata#5280) convert the examples for apply_ufunc to doctest (pydata#5279) fix the new whatsnew section Ensure `HighLevelGraph` layers are `Layer` instances (pydata#5271)
* upstream/master: (23 commits) combine keep_attrs and combine_attrs in apply_ufunc (pydata#5041) Explained what a deprecation cycle is (pydata#5289) Code cleanup (pydata#5234) FacetGrid docstrings (pydata#5293) Add whats new for dataset interpolation with non-numerics (pydata#5297) Allow dataset interpolation with different datatypes (pydata#5008) Flexible indexes: add Index base class and xindexes properties (pydata#5102) pre-commit: autoupdate hook versions (pydata#5280) convert the examples for apply_ufunc to doctest (pydata#5279) fix the new whatsnew section Ensure `HighLevelGraph` layers are `Layer` instances (pydata#5271) New whatsnew section Release-workflow: Bug fix (pydata#5273) more maintenance on whats-new.rst (pydata#5272) v0.18.0 release highlights (pydata#5266) Fix exception when display_expand_data=False for file-backed array. (pydata#5235) Warn ignored keep attrs (pydata#5265) Disable workflows on forks (pydata#5267) fix the built wheel test (pydata#5270) pypi upload workflow maintenance (pydata#5269) ...
…e_units * upstream/master: combine keep_attrs and combine_attrs in apply_ufunc (pydata#5041) Explained what a deprecation cycle is (pydata#5289) Code cleanup (pydata#5234) FacetGrid docstrings (pydata#5293) Add whats new for dataset interpolation with non-numerics (pydata#5297) Allow dataset interpolation with different datatypes (pydata#5008) Flexible indexes: add Index base class and xindexes properties (pydata#5102)
* upstream/master: Update release guide (pydata#5274) combine keep_attrs and combine_attrs in apply_ufunc (pydata#5041) Explained what a deprecation cycle is (pydata#5289) Code cleanup (pydata#5234) FacetGrid docstrings (pydata#5293) Add whats new for dataset interpolation with non-numerics (pydata#5297) Allow dataset interpolation with different datatypes (pydata#5008)
As discussed this extends
keep_attrsinapply_ufuncto also accept merge strategy names and usemerge_attrs(making it easier to add more merge strategies).Handling
attrson variables / coords is still missing.pre-commit run --all-fileswhats-new.rst