Uh oh!
There was an error while loading. Please reload this page.
Add deprecation warnings for lock kwarg - #5237
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
| # TODO remove after v0.19 | ||
| if kwargs.pop("lock", None): | ||
| warnings.warn( | ||
| "The kwarg 'lock' has been deprecated, and is now " | ||
| "ignored. In the future passing lock will " | ||
| "raise an error.", | ||
| DeprecationWarning, | ||
| ) |
There was a problem hiding this comment.
should we include the target version in the warning and remove the comment?
There was a problem hiding this comment.
I did that originally but Max said above that it might be better to leave it out... I think this is fine to be honest.
There was a problem hiding this comment.
hmm... in any case, I think it would be good to keep the error message for open_dataset and open_dataarray synchronized
There was a problem hiding this comment.
We could always add a specific date of deprecation later on, even if that would extend the cycle. It doesn't really matter if this check just sits here for a while I suppose.
Oh I didn't mean to make them different! Will fix now.
alexamici
commented
May 4, 2021
@TomNicholas see my comment here: #5073 (comment) I think the best course for now is to only raise the deprecation warning in zarr and pydap, as al other in-tree backends actually support the |
keewis
commented
May 4, 2021
I think this should have been closed by #5256. Please reopen if I misunderstood. |
Does this need a test?
lockkwarg needs a deprecation cycle? #5073pre-commit run --all-fileswhats-new.rst