Uh oh!
There was an error while loading. Please reload this page.
Add coarsen.construct - #5476
Conversation
Hello @dcherian! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-06-23 16:18:22 UTC |
mathause
left a comment
There was a problem hiding this comment.
Looks good I left some minor comments. I have not looked at the moved tests.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
…rsen_reshape * 'coarsen_reshape' of github.com:dcherian/xarray: Apply suggestions from code review
dcherian
commented
Jun 21, 2021
This should be ready for review & merge |
* main: Improve error message for guess engine (pydata#5455) Refactor dataset groupby tests (pydata#5506) DOC: zarr note on encoding (pydata#5427) Allow plotting categorical data (pydata#5464)
dcherian
commented
Jun 24, 2021
Thanks for the review @mathause |
pre-commit run --all-fileswhats-new.rstapi.rstBuilds on #5474
Here's an example
What do people think of this syntax:
{"time": ("year", "month"), "x": ("x", "x_reshaped")? Should we instead do{"time": "month", "x": "x_reshaped"}and have the user later rename thexortimedimension if they want?