Skip to content

DEP: Deprecate rasterio backend - #5808

Merged
keewis merged 6 commits into
pydata:mainfrom
snowman2:deprecate_rio
Oct 2, 2021
Merged

DEP: Deprecate rasterio backend#5808
keewis merged 6 commits into
pydata:mainfrom
snowman2:deprecate_rio

Conversation

@snowman2

@snowman2snowman2 commented Sep 22, 2021

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Sep 22, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Unit Test Results

6 files ±0 6 suites ±0 54m 51s ⏱️ ±0s
16 226 tests ±0 14 491 ✔️ ±0 1 735 💤 ±0 0 ❌ ±0 
90 552 runs ±0 82 367 ✔️ ±0 8 185 💤 ±0 0 ❌ ±0 

Results for commit 5499949. ± Comparison against base commit 5499949.

♻️ This comment has been updated with latest results.

@snowman2
snowman2 marked this pull request as ready for review September 22, 2021 01:39
@snowman2

snowman2 commented Sep 22, 2021

Copy link
Copy Markdown
ContributorAuthor

Fix for doc build issues in #5805

@keewis

keewis commented Sep 24, 2021

Copy link
Copy Markdown
Collaborator

thanks, @snowman2, looks good to me. We definitely need a whats-new.rst entry for this, though. Once that is done I think we can merge this (unless we're planning to release 0.19.1 first?)

@snowman2

snowman2 commented Sep 25, 2021

Copy link
Copy Markdown
ContributorAuthor

Updated this so it is deprecated in 0.19.1 and added an entry to whats-new.rst.

keewis
keewis reviewed Sep 28, 2021
View reviewed changes

@keewiskeewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update, @snowman2. I've got some minor suggestions but otherwise looks good to me.

As far as I remember we never used the deprecated directive in xarray before... it could be useful to add that for other deprecations, too, though.

Comment threadxarray/backends/rasterio_.py Outdated
Comment threaddoc/whats-new.rst Outdated
snowman2and others added 4 commits September 28, 2021 16:40
@snowman2@keewis
DOC: remove experimental
51d026d
Co-authored-by: keewis <keewis@users.noreply.github.com>
@snowman2@keewis
DOC: open rasterio in what's new
8e80e8e
Co-authored-by: keewis <keewis@users.noreply.github.com>
@keewis
add a note to update deprecations on version change before releasing
03946c8
@keewis
add the github handle [skip-ci]
6ac8227
@keewis

keewis commented Sep 30, 2021•
edited
Loading

Copy link
Copy Markdown
Collaborator

I just pushed a rst comment reminding us to update the deprecation version if we skip 0.19.1, but if I remember the meeting correctly this should now be ready for merging.

Thanks a lot, @snowman2

@keewiskeewis added the plan to merge Final call for comments label Sep 30, 2021
@weiji14weiji14 mentioned this pull request Oct 1, 2021
Open
5 tasks
@keewis

keewis commented Oct 2, 2021•
edited
Loading

Copy link
Copy Markdown
Collaborator

Merging. Thanks again, @snowman2

@keewis
keewis merged commit 5499949 into pydata:mainOct 2, 2021
@snowman2

snowman2 commented Oct 2, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review 👍

@snowman2
snowman2 deleted the deprecate_rio branch October 2, 2021 21:03
@dcherian

dcherian commented Oct 4, 2021

Copy link
Copy Markdown
Contributor

Thanks @snowman2 This is awesome!

cheginit added a commit to hyriver/pygeoutils that referenced this pull request Nov 4, 2021
@cheginit
ENH: Use rioxarray for dealing with geotiff binaries since xarray.ope…
4f27696
…n_rasterio is deprecated pydata/xarray#5808 [skip ci]
cheginit added a commit to hyriver/py3dep that referenced this pull request Nov 4, 2021
@cheginit
ENH: Use rioxarray for dealing with geotiff binaries since xarray.ope…
8710600
…n_rasterio is deprecated pydata/xarray#5808 [skip ci]
@sjvrijnsjvrijn mentioned this pull request Jan 12, 2022
Closed
snowman2 added a commit to snowman2/xarray that referenced this pull request Feb 9, 2022
@snowman2@keewis
DEP: Deprecate rasterio backend (pydata#5808)
afaae39
* DEP: Deprecate rasterio backend
* DOC: remove experimental
Co-authored-by: keewis <keewis@users.noreply.github.com>
* DOC: open rasterio in what's new
Co-authored-by: keewis <keewis@users.noreply.github.com>
* add a note to update deprecations on version change before releasing
* add the github handle [skip-ci]
Co-authored-by: keewis <keewis@users.noreply.github.com>
Co-authored-by: Keewis <keewis@posteo.de>
@IllviljanIllviljan mentioned this pull request Oct 16, 2022
Merged
2 tasks
@scottyhqscottyhq mentioned this pull request Mar 24, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keewiskeewiskeewis left review comments

Assignees

No one assigned

Labels

plan to mergeFinal call for comments

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

deprecate open_rasterio in favour of a rioxarray entrypoint?

3 participants

@snowman2@keewis@dcherian