Uh oh!
There was an error while loading. Please reload this page.
Use condas dask-core in ci instead of dask to speedup ci and reduce dependencies - #6007
Merged
Conversation
aaronspring
marked this pull request as draft
November 20, 2021 23:27
aaronspring
marked this pull request as ready for review
November 23, 2021 23:59
aaronspring
commented
Nov 24, 2021
ContributorAuthor
bokeh etc not installed anymore when temporarily not installing iris from conda https://github.com/pydata/xarray/runs/4298565586?check_suite_focus=true |
Uh oh!
There was an error while loading. Please reload this page.
dcherian
approved these changes
Nov 24, 2021
dcherian added a commit
to dcherian/xarray
that referenced
this pull request
Dec 2, 2021
* upstream/main: fix grammatical typo in docs (pydata#6034) Use condas dask-core in ci instead of dask to speedup ci and reduce dependencies (pydata#6007) Use complex nan by default when interpolating out of bounds (pydata#6019) Simplify missing value handling in xarray.corr (pydata#6025) Add pyXpcm to Related Projects doc page (pydata#6031) Make xr.corr and xr.map_blocks work without dask (pydata#5731)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-fileswhats-new.rstapi.rstTried to reduce dependencies from installing dask via conda which installs like pip install dask[complete]. dask-core is like pip install dask. xgcm/xhistogram#71 (comment)
Why? dask[complete] includes bokeh etc which are not needed here and likely speed up CI setup/install times
but now dask and dask-core are conda installed :( seems like iris installs dask https://github.com/conda-forge/iris-feedstock/blob/master/recipe/meta.yaml, so this would require an iris-feedstock PR first
linking SciTools/iris#4434 and conda-forge/iris-feedstock#77