Uh oh!
There was an error while loading. Please reload this page.
MNT: prepare h5netcdf backend for (coming) change in dimension handling - #6200
Conversation
kmuehlbauer
commented
Jan 27, 2022
- Closes⚠️ Nightly upstream-dev CI failed ⚠️ #6197
kmuehlbauer
commented
Jan 27, 2022
@mathause Although I'm pretty sure that this fixes the upstream-dev run, it would be good to verify. Is it possible to run the upstream-dev with this PR? |
kmuehlbauer
commented
Jan 27, 2022
I'd also like to add fixes to silence new FutureWarnings emitted by |
mathause
commented
Jan 27, 2022
Great! Thanks for the fix. Yes the string |
kmuehlbauer
commented
Jan 27, 2022
Could you please have a look at the chunksizes FutureWarnings (eg. here https://github.com/pydata/xarray/runs/4965336696?check_suite_focus=true#step:8:344). Are the chunksizes via |
kmuehlbauer
commented
Jan 27, 2022
@mathause The fix is applied and works. We have some issues with |
Looks good. The remaining upstream failure does not seem to be related. |
dionhaefner
commented
Jan 27, 2022
Let's take this in h5netcdf/h5netcdf#149. |
mathause
commented
Jan 29, 2022
Thanks @kmuehlbauer! |
|
mathause
commented
Jan 29, 2022
Sorry I was wrong - this was not the cause for the test failure. Let's keep this as is. |