Skip to content

Add cumsum to DatasetGroupBy - #6525

Merged
dcherian merged 17 commits into
pydata:mainfrom
dcherian:groupby-cumsum
Jul 20, 2022
Merged

Add cumsum to DatasetGroupBy#6525
dcherian merged 17 commits into
pydata:mainfrom
dcherian:groupby-cumsum

Conversation

@dcherian

@dcheriandcherian commented Apr 27, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

@dcheriandcherian mentioned this pull request Apr 27, 2022
Closed
3 tasks
@dcheriandcherian mentioned this pull request Apr 27, 2022
Closed
max-sixty
max-sixty approved these changes Apr 27, 2022
View reviewed changes

@max-sixtymax-sixty left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your call, but I would vote to merge with the existing index issue...

@dcherian

dcherian commented Apr 28, 2022

Copy link
Copy Markdown
ContributorAuthor

Your call, but I would vote to merge with the existing index issue...

Modified the test, it is quite buggy for Datasets

dcherianand others added 6 commits April 28, 2022 09:30
@dcherian
[skip-ci] Add to api.rst
bcbe801
@dcherian
Merge branch 'main' into groupby-cumsum
b0d42d2
* main:
Pin version of black in pre-commit blackdoc (pydata#6492)
Scale numfocus image in readme (pydata#6519)
Use new importlib.metadata.entry_points interface where available. (pydata#6516)
Add a badge for binder (pydata#6518)
Bump codecov/codecov-action from 3.0.0 to 3.1.0 (pydata#6509)
@dcherian
Merge remote-tracking branch 'upstream/main' into groupby-cumsum
e8ec1b2
* upstream/main:
Add a slighly cheesy contributors panel to readme (pydata#6520)
Fix doctest & mypy CI jobs (pydata#6535)
Attempt to improve CI caching (pydata#6534)
Attempt to consolidate tests in CI (pydata#6533)
Restrict annotations to a single run in GHA (pydata#6532)
Fix some mypy issues (pydata#6531)
@max-sixty
Merge branch 'main' into groupby-cumsum
f6a58eb
@Illviljan
Merge branch 'main' into pr/6525
d378d55
@Illviljan
Merge branch 'main' into pr/6525
52e4fb2
Illviljan
Illviljan approved these changes Jul 12, 2022
View reviewed changes
Comment threadxarray/tests/test_groupby.py Outdated
@dcherian@Illviljan
Update xarray/tests/test_groupby.py
944bd02
Co-authored-by: Illviljan <14371165+Illviljan@users.noreply.github.com>
Illviljan
Illviljan reviewed Jul 12, 2022
View reviewed changes
Comment threadxarray/core/groupby.py Outdated
Comment threadxarray/core/groupby.py Outdated
Illviljan
Illviljan reviewed Jul 12, 2022
View reviewed changes
Comment threadxarray/tests/test_groupby.py Outdated
@andersy005

andersy005 commented Jul 16, 2022

Copy link
Copy Markdown
Member

@dcherian, are you still working on this or can we merge it?

@dcherian

dcherian commented Jul 16, 2022

Copy link
Copy Markdown
ContributorAuthor

We could merge. The outstanding issue to fix is actually #6528

@IllviljanIllviljan added the plan to merge Final call for comments label Jul 16, 2022
@dcherian
dcherian merged commit dabd977 into pydata:mainJul 20, 2022
@dcherian
dcherian deleted the groupby-cumsum branch July 20, 2022 01:31
dcherian added a commit to keewis/xarray that referenced this pull request Jul 22, 2022
@dcherian
Merge branch 'main' into duckarray-tests
21a5838
* main: (313 commits)
Update whats-new
Release notes for v2022.06.0 (pydata#6815)
Drop multi-indexes when assigning to a multi-indexed variable (pydata#6798)
Support NumPy array API (experimental) (pydata#6804)
Add cumsum to DatasetGroupBy (pydata#6525)
Refactor groupby binary ops code. (pydata#6789)
Update DataArray.rename + docu (pydata#6665)
Switch to T_DataArray and T_Dataset in concat (pydata#6784)
Fix typos found by codespell (pydata#6794)
Update groupby attrs tests (pydata#6787)
Update map_blocks to use chunksizes property. (pydata#6776)
Fix `DataArrayRolling.__iter__` with `center=True` (pydata#6744)
[test-upstream] Update flox repo URL (pydata#6780)
Move _infer_meta_data and _parse_size to utils (pydata#6779)
Make the `sel` error more descriptive when `method` is unset (pydata#6774)
Move Rolling tests to their own testing module (pydata#6777)
[pre-commit.ci] pre-commit autoupdate (pydata#6773)
move da and ds fixtures to conftest.py (pydata#6730)
Bump EnricoMi/publish-unit-test-result-action from 1 to 2 (pydata#6770)
Type shape methods (pydata#6767)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IllviljanIllviljanIllviljan approved these changes
@max-sixtymax-sixtymax-sixty approved these changes

Assignees

No one assigned

Labels

plan to mergeFinal call for comments

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

calculating cumsums on a groupby object

5 participants

@dcherian@andersy005@max-sixty@Illviljan@VladSkripniuk