Skip to content

Remove duplicate tests, v2 - #6541

Closed
max-sixty wants to merge 3 commits into
mainfrom
revert-6540-revert-6536-gha-remone-duplicate
Closed

Remove duplicate tests, v2#6541
max-sixty wants to merge 3 commits into
mainfrom
revert-6540-revert-6536-gha-remone-duplicate

Conversation

@max-sixty

Copy link
Copy Markdown
Collaborator

Reverts #6540

I'll figure out why we lost a couple tests

@max-sixtymax-sixty changed the title Remove duplicate tests, v2Draft: Remove duplicate tests, v2Apr 29, 2022
@max-sixtymax-sixty changed the title Draft: Remove duplicate tests, v2Remove duplicate tests, v2Apr 30, 2022
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
# Bookend python versions
python-version: ["3.8", "3.10"]
env: [""]

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the issue — it doesn't by default add a blank env to the matrix

@max-sixtymax-sixty mentioned this pull request Apr 30, 2022
@max-sixty

Copy link
Copy Markdown
CollaboratorAuthor

Replaced by #6550

@max-sixty
max-sixty deleted the revert-6540-revert-6536-gha-remone-duplicate branch April 30, 2022 20:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@max-sixty