Skip to content

thin: add examples - #6663

Merged
andersy005 merged 20 commits into
pydata:mainfrom
e-marshall:tail_add_example
Jun 7, 2022
Merged

thin: add examples#6663
andersy005 merged 20 commits into
pydata:mainfrom
e-marshall:tail_add_example

Conversation

@e-marshall

@e-marshalle-marshall commented Jun 3, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

@dcherian

dcherian commented Jun 3, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks @e-marshall

The doctest failure is because you need to delete a few spaces to align 17 ... (I clicked "details" to see this).
image

@e-marshall

e-marshall commented Jun 3, 2022

Copy link
Copy Markdown
ContributorAuthor

Thanks @e-marshall

The doctest failure is because you need to delete a few spaces to align 17 ... (I clicked "details" to see this). image

Ok, thanks @dcherian , I'll make those changes

dcherian
dcherian reviewed Jun 3, 2022
View reviewed changes
Comment threadxarray/core/dataarray.py Outdated
Comment threadxarray/core/dataset.py Outdated
Comment threadxarray/core/dataarray.py
dcherian
dcherian reviewed Jun 3, 2022
View reviewed changes
Comment threadxarray/core/dataarray.py Outdated
dcherian
dcherian reviewed Jun 3, 2022
View reviewed changes
Comment threadxarray/core/dataset.py Outdated
e-marshalland others added 3 commits June 3, 2022 17:25
dcherian
dcherian reviewed Jun 3, 2022
View reviewed changes
Comment threadxarray/core/dataarray.py
@dcherian

dcherian commented Jun 3, 2022

Copy link
Copy Markdown
Contributor

Here's how you can run the doctests locally in an environment created using

mamba env create -f ci/requirements/environment.yml

conda activate xarray-tests
pytest --doctest-modules xarray --ignore xarray/tests

@e-marshall

e-marshall commented Jun 3, 2022

Copy link
Copy Markdown
ContributorAuthor

Here's how you can run the doctests locally in an environment created using

mamba env create -f ci/requirements/environment.yml

conda activate xarray-tests
pytest --doctest-modules xarray --ignore xarray/tests

Okay, thanks ! I'll give that a try

@dcherian

dcherian commented Jun 6, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks @e-marshall Doctests pass and the unrelated test failures should be fixed by #6667

@dcherian
dcherian marked this pull request as ready for review June 7, 2022 18:28
@dcheriandcherian changed the title Tail add examplethin: add examplesJun 7, 2022
andersy005
andersy005 approved these changes Jun 7, 2022
View reviewed changes

@andersy005andersy005 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @e-marshall for this addition and welcome to xarray 🥳🎉

@andersy005
andersy005 merged commit 56f05c3 into pydata:mainJun 7, 2022
dcherian added a commit to dcherian/xarray that referenced this pull request Jun 12, 2022
@dcherian
Merge branch 'main' into groupby-refactor-init
6bd276c
* main:
pass kwargs through from save_mfdataset to to_netcdf (pydata#6686)
Docs: indexing.rst finetuning (pydata#6685)
use micromamba instead of mamba (pydata#6674)
install the development version of `matplotlib` into the upstream-dev CI (pydata#6675)
Add whatsnew section for v2022.06.0
release notes for 2022.06.0rc0
release notes for the pre-release (pydata#6676)
more testpypi workflow fixes (pydata#6673)
thin: add examples (pydata#6663)
Update multidimensional-coords.ipynb (pydata#6672)
try to finally fix the TestPyPI workflow (pydata#6671)
pin setuptools in the modify script (pydata#6669)
fix the python version for the TestPyPI workflow (pydata#6668)
upload wheels from `main` to TestPyPI (pydata#6660)
Set keep_attrs for flox (pydata#6667)
dcherian added a commit to abel-bzz/xarray that referenced this pull request Jun 24, 2022
@dcherian
Merge branch 'main' into fix/dask_indexing
d5e7646
* main: (129 commits)
docs on specifying chunks in to_zarr encoding arg (pydata#6542)
[skip-ci] List count under Aggregation (pydata#6711)
Add `Dataset.dtypes` property (pydata#6706)
try to import `UndefinedVariableError` from the new location (pydata#6701)
DOC: note of how `chunks` can be defined (pydata#6696)
pdyap version dependent client.open_url call (pydata#6656)
use `pytest-reportlog` to generate upstream-dev CI failure reports (pydata#6699)
[pre-commit.ci] pre-commit autoupdate (pydata#6694)
Bump actions/setup-python from 3 to 4 (pydata#6692)
Fix Dataset.where with drop=True and mixed dims (pydata#6690)
pass kwargs through from save_mfdataset to to_netcdf (pydata#6686)
Docs: indexing.rst finetuning (pydata#6685)
use micromamba instead of mamba (pydata#6674)
install the development version of `matplotlib` into the upstream-dev CI (pydata#6675)
Add whatsnew section for v2022.06.0
release notes for 2022.06.0rc0
release notes for the pre-release (pydata#6676)
more testpypi workflow fixes (pydata#6673)
thin: add examples (pydata#6663)
Update multidimensional-coords.ipynb (pydata#6672)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcheriandcheriandcherian left review comments
@andersy005andersy005andersy005 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@e-marshall@dcherian@andersy005@keewis