Add dataarray scatter by Illviljan · Pull Request #6778 · pydata/xarray

Illviljan · 2022-07-12T18:44:29Z

Splitting up #5622 as the scope of it has grown too large now.

Adds support for dataarray scatter plots and replaces the dataset version.
Scatter now has 3d support with the z argument.
Scatter now always returns a single pathcollection, earlier it could return a list of pathcollection when using categoricals
Better legend, handles now categoricals. Making continous/discrete options slightly redundant, still there though.
Facetgrid generalized slightly to handle 3d plots.

TODO:

sharex sharey test Set sharex/sharey to False if using 3d plots #7047: len(list(ax.get_shared_x_axes())) != 0

Tests added
User visible changes (including notable bug fixes) are documented in whats-new.rst
New functions/methods are listed in api.rst

* use coords to check if valid * only normalize sizes, hue is not necessary. * Use same scatter parameter order as the dataset version. * Fix tests assuming a list of patchollections is returned.

for more information, see https://pre-commit.ci

…xarray into add_dataarray_scatter

for more information, see https://pre-commit.ci

Illviljan · 2022-10-05T02:51:05Z

I'm merging this soon. Will hopefully go smoothly.

headtr1ck · 2022-10-06T21:36:33Z

I'm merging this soon. Will hopefully go smoothly.

I will wait with merging #7052
and then try to fix the merge conflicts :)

dcherian · 2022-10-07T18:23:47Z

Thanks @Illviljan !

mathause · 2022-10-07T19:37:18Z

Nice work!

Illviljan added 30 commits February 14, 2021 11:49

allow adding any number of extra coords
e10d5ca

Explain how ds will becom darray
474928f

Update dataset_plot.py
54bd639

Merge branch 'master' into Illviljan-dataset_line_plot
f58c52a

Update dataset_plot.py
a8edc08

use coords for coords
9c416f2

Merge branch 'master' into Illviljan-dataset_line_plot
3ade6c4

Merge branch 'master' into Illviljan-dataset_line_plot
c14ae47

Merge branch 'master' into Illviljan-dataset_line_plot
93b50e2

Explain goal of moving ds plots to da
7110220

Merge branch 'master' into Illviljan-dataset_line_plot
76d42e5

Merge branch 'main' into Illviljan-dataset_line_plot
b8c749d

Merge branch 'main' into Illviljan-dataset_line_plot
3e90c1f

Update dataset_plot.py
72c8e81

Update dataset_plot.py
79dd87a

Update dataset_plot.py
7b8fe1d

handle non-existant coords
bf8b0ea

Update dataset_plot.py
424a006

Look through the kwargs to find extra coords
fe5bece

output of legend labels has changed
8d5f5c6

pop plt, comment out error test
a26992c

Merge branch 'Illviljan-dataset_line_plot' into remove_dataset_scatter
61ba8db

Update dataset_plot.py
f130b85

Update facetgrid.py
89515ef

move some funcs to utils
a7ee9f6

add the funcs to the moved place
450c075

Merge branch 'main' into remove_dataset_scatter
d70184a

various bugfixes
5efcf12
* use coords to check if valid * only normalize sizes, hue is not necessary. * Use same scatter parameter order as the dataset version. * Fix tests assuming a list of patchollections is returned.

improve ds to da wrapper
ac60266

Filter kwargs
d33a8da

This was referenced Sep 16, 2022
Add helper for setting axis limits in facetgrid #7046
Merged
Set sharex/sharey to False if using 3d plots #7047
Merged

Merge branch 'main' into add_dataarray_scatter
1be6746

github-actionsBot removed the topic-typing label Sep 17, 2022

Illviljan mentioned this pull request Sep 24, 2022
Add typing to plot methods #7052
Merged
3 tasks

Illviljanand others added 12 commits September 25, 2022 17:36

Merge branch 'main' into add_dataarray_scatter
6bd2354

Merge branch 'main' into add_dataarray_scatter
699dd79

[pre-commit.ci] auto fixes from pre-commit.com hooks
7ba3da3
for more information, see https://pre-commit.ci

Merge branch 'main' into add_dataarray_scatter
d8d90b5

Update facetgrid.py
f8aec60

fix some mypy errors
c5f652f

Merge branch 'main' into add_dataarray_scatter
566103b

[pre-commit.ci] auto fixes from pre-commit.com hooks
dbc3368
for more information, see https://pre-commit.ci

Update plot.py
f76b5a3

Merge branch 'add_dataarray_scatter' ofhttps://github.com/Illviljan/…
96ad382
…xarray into add_dataarray_scatter

[pre-commit.ci] auto fixes from pre-commit.com hooks
f5660e0
for more information, see https://pre-commit.ci

Update plot.py
34b1b98

Illviljan added the plan to merge Final call for comments label Oct 5, 2022

Illviljanand others added 3 commits October 5, 2022 23:05

Update whats-new.rst
ea5266c

Merge branch 'main' into add_dataarray_scatter
bd01f9c

Merge branch 'main' into add_dataarray_scatter
f676f89

Illviljan merged commit 8dac64b into pydata:mainOct 7, 2022

benjeffery mentioned this pull request Oct 17, 2022
gwas_tutorial.ipynb taking too long to run. sgkit-dev/sgkit#934
Open

Illviljan mentioned this pull request Oct 17, 2022
Fix some scatter plot issues #7167
Merged

Illviljan mentioned this pull request Jun 14, 2023
plot.scatter(hue_style="discrete") does nothing #7907
Closed
4 tasks

Illviljan mentioned this pull request Aug 6, 2024
Replace dataset scatter with the dataarray version #5622
Closed
5 tasks

Navigation Menu

Uh oh!

Uh oh!

Add dataarray scatter - #6778

Add dataarray scatter#6778
Illviljan merged 261 commits into
pydata:mainfrom
Illviljan:add_dataarray_scatter

Illviljan commented Jul 12, 2022•
edited
Loading

Uh oh!

Illviljan commented Oct 5, 2022

Uh oh!

headtr1ck commented Oct 6, 2022

Uh oh!

dcherian commented Oct 7, 2022

Uh oh!

mathause commented Oct 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

Illviljan commented Jul 12, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Illviljan commented Oct 5, 2022

Uh oh!

headtr1ck commented Oct 6, 2022

Uh oh!

dcherian commented Oct 7, 2022

Uh oh!

mathause commented Oct 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Illviljan commented Jul 12, 2022•
edited
Loading