Uh oh!
There was an error while loading. Please reload this page.
(scipy 2022 branch) Add an "options" argument to Index.from_variables() - #6800
Closed
benbovy wants to merge 2 commits into
Closed
(scipy 2022 branch) Add an "options" argument to Index.from_variables()#6800benbovy wants to merge 2 commits into
benbovy wants to merge 2 commits into
Conversation
It allows passing options to the constructor of a custom index class (if any). The **options arguments of Dataset.set_xindex() are passed through. Also add type annotations to set_xindex().
5 tasks
benbovy
commented
Sep 2, 2022
MemberAuthor
See #6971. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It allows passing options to the constructor of a custom
Indexsubclass, in case there's any relevant build options to expose to users. This could for example be the distance metric chosen for an index based onsklearn.neighbors.BallTree, or the CRS definition for a geospatial index.The
**optionsarguments ofDataset.set_xindex()are passed through.An alternative way would be to pass options via coordinate metadata, like the
spatial_refcoordinate in rioxarray. Perhaps both alternatives may co-exist?This PR also adds type annotations to
set_xindex().