Skip to content

Remove dask_array_type checks - #7023

Merged
TomNicholas merged 8 commits into
pydata:mainfrom
TomNicholas:remove_dask_array_type_checks
Sep 13, 2022
Merged

Remove dask_array_type checks#7023
TomNicholas merged 8 commits into
pydata:mainfrom
TomNicholas:remove_dask_array_type_checks

Conversation

@TomNicholas

@TomNicholasTomNicholas commented Sep 12, 2022

Copy link
Copy Markdown
Member

@github-actionsgithub-actionsBot added the topic-arrays related to flexible array support label Sep 12, 2022
TomNicholas
TomNicholas commented Sep 12, 2022
View reviewed changes
Comment threadxarray/core/variable.py
@TomNicholasTomNicholas mentioned this pull request Sep 12, 2022
Merged
15 tasks
TomNicholas
TomNicholas commented Sep 12, 2022
View reviewed changes
Comment threadxarray/core/arithmetic.py Outdated
TomNicholas
TomNicholas commented Sep 12, 2022
View reviewed changes
Comment threadxarray/core/variable.py
@TomNicholas

TomNicholas commented Sep 12, 2022

Copy link
Copy Markdown
MemberAuthor

Okay I think this is as done as it can be, though we didn't manage to completely remove dask_array_type or cupy_array_type.

dask_array_type is now only needed in the repr though... #4324

@mathause

mathause commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator

Interesting - did not think that this would work. Potential follow up - make all imports of dask lazy (#6726).

dcherian
dcherian approved these changes Sep 12, 2022
View reviewed changes

@dcheriandcherian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Thanks @TomNicholas

Error: test_xarray_handles_dask
Error: test_dask_defers_to_xarray

Seems like these two should be in the duck array test suite

@TomNicholasTomNicholas mentioned this pull request Sep 13, 2022
Open
19 tasks
@TomNicholas

TomNicholas commented Sep 13, 2022

Copy link
Copy Markdown
MemberAuthor

Seems like these two should be in the duck array test suite

The extensible public duck array test suite isn't in main yet, so I made a note of it for now #6894 (comment)

@TomNicholas
TomNicholas merged commit 073f414 into pydata:mainSep 13, 2022
@TomNicholas
TomNicholas deleted the remove_dask_array_type_checks branch September 13, 2022 00:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcheriandcheriandcherian approved these changes

Assignees

No one assigned

Labels

topic-arraysrelated to flexible array supporttopic-dask

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TomNicholas@mathause@dcherian