Uh oh!
There was an error while loading. Please reload this page.
Array API fixes for astype - #7815
Closed
TomNicholas wants to merge 156 commits into
Closed
Conversation
for more information, see https://pre-commit.ci
…rray into cubed_integration
This reverts commit cdcb3fb.
for more information, see https://pre-commit.ci
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…rray into cubed_integration
for more information, see https://pre-commit.ci
…rray into cubed_integration
This reverts commit 9cd9078.
15 tasks
TomNicholas
commented
May 9, 2023
MemberAuthor
Just merged in #7820, which should hopefully fix this 🤞 |
4 tasks
TomNicholas
commented
May 18, 2023
MemberAuthor
Closing in favour of #7847 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it's common for duck arrays to have a
.astypemethod, this doesn't exist in the new array API standard. We now haveduck_array_ops.astypeto deal with this, but for some reason changing it in just a couple more places broke practically every pint test intest_units.py😕 @keewisBuilds on top of #7019 with just one extra commit to separate out this issue.
whats-new.rstapi.rst