Skip to content

ensure no forward slashes in names for HDF5-based backends - #7953

Merged
dcherian merged 7 commits into
pydata:mainfrom
kmuehlbauer:ensure-no-forward-slash
Jul 6, 2023
Merged

ensure no forward slashes in names for HDF5-based backends#7953
dcherian merged 7 commits into
pydata:mainfrom
kmuehlbauer:ensure-no-forward-slash

Conversation

@kmuehlbauer

Copy link
Copy Markdown
Contributor

@headtr1ckheadtr1ck left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Comment threadxarray/backends/netCDF4_.py
Comment threadxarray/backends/netCDF4_.py Outdated

@jhammanjhamman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion but this looks great.

Co-authored-by: Joe Hamman <jhamman1@gmail.com>
@kmuehlbauerkmuehlbauer added the plan to merge Final call for comments label Jul 4, 2023
@dcherian
dcherian merged commit 17c9e8f into pydata:mainJul 6, 2023
dcherian added a commit to dcherian/xarray that referenced this pull request Jul 16, 2023
* main:
Remove hue_style from plot1d docstring (pydata#7925)
Add new what's new section (pydata#7986)
Release summary for v2023.07.0 (pydata#7979)
Improve explanation in example "Working with Multidimensional Coordinates" (pydata#7984)
Fix typo in zarr.py (pydata#7983)
Examples added to docstrings (pydata#7936)
[pre-commit.ci] pre-commit autoupdate (pydata#7973)
Skip broken tests on python 3.11 and windows (pydata#7972)
Use another repository for upstream testing (pydata#7970)
Move absolute path finder from open_mfdataset to own function (pydata#7968)
ensure no forward slashes in names for HDF5-based backends (pydata#7953)
Chunked array docs (pydata#7951)
[pre-commit.ci] pre-commit autoupdate (pydata#7959)
manually unshallow the repository on RTD (pydata#7961)
Update minimum version of typing extensions in pre-commit (pydata#7960)
Docstring examples (pydata#7881)
@kmuehlbauer
kmuehlbauer deleted the ensure-no-forward-slash branch December 16, 2024 08:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ioplan to mergeFinal call for commentstopic-backends

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'/' in variable name causes to_netcdf() to crash

4 participants

@kmuehlbauer@jhamman@headtr1ck@dcherian