Skip to content

Docs page on interoperability - #7992

Merged
TomNicholas merged 32 commits into
pydata:mainfrom
TomNicholas:docs_interoperability
Oct 26, 2023
Merged

Docs page on interoperability#7992
TomNicholas merged 32 commits into
pydata:mainfrom
TomNicholas:docs_interoperability

Conversation

@TomNicholas

@TomNicholasTomNicholas commented Jul 17, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Builds upon #7991 by adding a page to the internals enumerating all the different ways in which xarray is interoperable.

Would be nice if #6975 were merged so that I could link to it from this new page.

Illviljan
Illviljan reviewed Jul 25, 2023
View reviewed changes
Comment threaddoc/internals/internal-design.rst Outdated
@trexfeathers

trexfeathers commented Jul 25, 2023

Copy link
Copy Markdown

@pp-mo 👀

max-sixty
max-sixty approved these changes Oct 4, 2023
View reviewed changes

@max-sixtymax-sixty left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Comment threaddoc/internals/interoperability.rst Outdated
Comment threaddoc/internals/interoperability.rst

@max-sixtymax-sixtyOct 4, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool page!

@max-sixty

max-sixty commented Oct 4, 2023

Copy link
Copy Markdown
Collaborator

This just came up on my notifications — looks great — shall we merge?

@TomNicholas

TomNicholas commented Oct 4, 2023

Copy link
Copy Markdown
MemberAuthor

You must be getting a lot of notifications if you got one just because I committed here!
🤯

Yes great I was just waiting for an approval - will merge shortly.

TomNicholasand others added 2 commits October 4, 2023 15:17
@TomNicholas@max-sixty
reword lack of support for subclassing
b2b8338
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
@TomNicholas
Merge branch 'main' into docs_interoperability
1f9c17c
TomNicholas
TomNicholas commented Oct 4, 2023
View reviewed changes
Comment threaddoc/internals/interoperability.rst Outdated
TomNicholas
TomNicholas commented Oct 4, 2023
View reviewed changes
Comment threaddoc/internals/interoperability.rst Outdated
@TomNicholas
TomNicholas enabled auto-merge (squash) October 4, 2023 19:23
@TomNicholas
TomNicholas merged commit 78f7491 into pydata:mainOct 26, 2023
@TomNicholas
TomNicholas deleted the docs_interoperability branch October 26, 2023 16:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IllviljanIllviljanIllviljan left review comments
@max-sixtymax-sixtymax-sixty approved these changes

Assignees

No one assigned

Labels

needs reviewtopic-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TomNicholas@trexfeathers@max-sixty@Illviljan