Skip to content

mypy 1.6.0 passing - #8296

Merged
max-sixty merged 4 commits into
pydata:mainfrom
max-sixty:mypy-1.6
Oct 12, 2023
Merged

mypy 1.6.0 passing#8296
max-sixty merged 4 commits into
pydata:mainfrom
max-sixty:mypy-1.6

Conversation

@max-sixty

@max-sixtymax-sixty commented Oct 12, 2023

Copy link
Copy Markdown
Collaborator

I did the easy things, but will need help for the final couple on _typed_ops.py

Because we don't pin mypy (should we?), this blocks other PRs if we gate them on mypy passing

@max-sixtymax-sixty mentioned this pull request Oct 12, 2023
Merged
@max-sixtymax-sixty added the plan to merge Final call for comments label Oct 12, 2023
@max-sixty

max-sixty commented Oct 12, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Planning to merge this as it solves some of the issues, and I won't be able to fix the others in the short-term, lmk any comments prior

max-sixty
max-sixty commented Oct 12, 2023
View reviewed changes
Comment threadpyproject.toml
@max-sixty

max-sixty commented Oct 12, 2023

Copy link
Copy Markdown
CollaboratorAuthor

@headtr1ck thanks so much for the fast fix!

@max-sixty
max-sixty enabled auto-merge (squash) October 12, 2023 18:32
@headtr1ck

headtr1ck commented Oct 12, 2023

Copy link
Copy Markdown
Collaborator

I have fixed the remaining mypy errors, so this it good to go.

I think pinning mypy would be a good idea, especially with an auto-updater that creates a PR so we can fix the issues there. But this is not something I have ever done, so maybe someone else should have a go at this :)

@max-sixty

max-sixty commented Oct 12, 2023

Copy link
Copy Markdown
CollaboratorAuthor

especially with an auto-updater that creates a PR so we can fix the issues there

I'm very familiar with doing this on pyproject.toml dependencies — but not on conda / mamba — I think possibly this isn't supported...

@max-sixtymax-sixty changed the title Most of mypy 1.6.0 passingmypy 1.6.0 passingOct 12, 2023
@max-sixty
max-sixty merged commit 25e6e08 into pydata:mainOct 12, 2023
@max-sixty
max-sixty deleted the mypy-1.6 branch October 12, 2023 22:09
dcherian added a commit to dcherian/xarray that referenced this pull request Oct 14, 2023
@dcherian
Merge remote-tracking branch 'upstream/main' into kvikio-2
3d32187
* upstream/main: (46 commits)
xfail flaky test (pydata#8299)
Most of mypy 1.6.0 passing (pydata#8296)
Rename `reset_encoding` to `drop_encoding` (pydata#8287)
Enable `.rolling_exp` to work on dask arrays (pydata#8284)
Fix `GroupBy` import (pydata#8286)
Ask bug reporters to confirm they're using a recent version of xarray (pydata#8283)
Add pyright type checker (pydata#8279)
Improved typing of align & broadcast (pydata#8234)
Update ci-additional.yaml (pydata#8280)
Fix time encoding regression (pydata#8272)
Allow a function in `.sortby` method (pydata#8273)
make more args kw only (except 'dim') (pydata#6403)
Use duck array ops in more places (pydata#8267)
Don't raise rename warning if it is a no operation (pydata#8266)
Mandate kwargs on `to_zarr` (pydata#8257)
copy the `dtypes` module to the `namedarray` package. (pydata#8250)
Add xarray-regrid to ecosystem.rst (pydata#8270)
Use strict type hinting for namedarray (pydata#8241)
Update type annotation for center argument of dataaray_plot methods (pydata#8261)
[pre-commit.ci] pre-commit autoupdate (pydata#8262)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IllviljanIllviljanIllviljan left review comments
@headtr1ckheadtr1ckAwaiting requested review from headtr1ck

Assignees

No one assigned

Labels

plan to mergeFinal call for comments

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@max-sixty@headtr1ck@Illviljan