Skip to content

ENH: vendor SerializableLock from dask and use as default backend lock, adapt tests - #8571

Merged
kmuehlbauer merged 7 commits into
pydata:mainfrom
kmuehlbauer:serializable-lock
Jan 4, 2024
Merged

ENH: vendor SerializableLock from dask and use as default backend lock, adapt tests#8571
kmuehlbauer merged 7 commits into
pydata:mainfrom
kmuehlbauer:serializable-lock

Conversation

@kmuehlbauer

@kmuehlbauerkmuehlbauer commented Dec 22, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@kmuehlbauer

kmuehlbauer commented Dec 22, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Before moving forward here, I'd like to get feedback, if everything is OK with copying the code over from dask.

jhamman
jhamman reviewed Dec 22, 2023
View reviewed changes
Comment threadxarray/backends/dask_lock.py Outdated
@kmuehlbauer
kmuehlbauer marked this pull request as ready for review January 3, 2024 14:21
dcherian
dcherian reviewed Jan 3, 2024
View reviewed changes
Comment threaddoc/whats-new.rst Outdated
@dcherian

dcherian commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

Adding this lock might fix some of our xfails in test_backends.py. Mind taking a look at the windows ones?

@kmuehlbauer

kmuehlbauer commented Jan 3, 2024

Copy link
Copy Markdown
ContributorAuthor

@dcherian Yes, can have a look the coming days. I'll test first a bit on my windows box to not have to debug on CI.

@dcherian

dcherian commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

In that case, let's merge and remove the xfails later!

@kmuehlbauerkmuehlbauer changed the title ENH: fork SerializableLock from dask and use as default backend lock, adapt testsENH: vendor SerializableLock from dask and use as default backend lock, adapt testsJan 3, 2024
@dcheriandcherian added the plan to merge Final call for comments label Jan 3, 2024
@kmuehlbauer
kmuehlbauer merged commit 693f0b9 into pydata:mainJan 4, 2024
@kmuehlbauer
kmuehlbauer deleted the serializable-lock branch January 4, 2024 06:41
dcherian added a commit to dcherian/xarray that referenced this pull request Jan 4, 2024
@dcherian
Merge remote-tracking branch 'upstream/main' into init-zarr
1498c35
* upstream/main:
Faster encoding functions. (pydata#8565)
ENH: vendor SerializableLock from dask and use as default backend lock, adapt tests (pydata#8571)
Silence a bunch of CachingFileManager warnings (pydata#8584)
Bump actions/download-artifact from 3 to 4 (pydata#8556)
Minimize duplication in `map_blocks` task graph (pydata#8412)
[pre-commit.ci] pre-commit autoupdate (pydata#8578)
ignore a `DeprecationWarning` emitted by `seaborn` (pydata#8576)
Fix mypy type ignore (pydata#8564)
Support for the new compression arguments. (pydata#7551)
FIX: reverse index output of bottleneck move_argmax/move_argmin functions (pydata#8552)
kmuehlbauer added a commit to kmuehlbauer/xarray that referenced this pull request Jan 5, 2024
@kmuehlbauer
remove xfail in succession ofpydata#8571
2246a34
@kmuehlbauerkmuehlbauer mentioned this pull request Jan 5, 2024
Merged
@snowman2snowman2 mentioned this pull request Jul 8, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhammanjhammanjhamman left review comments
@dcheriandcheriandcherian approved these changes

Assignees

No one assigned

Labels

plan to mergeFinal call for comments

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot pickle '_thread.lock' object exception after DataArray transpose and copy operations from netCDF file.

3 participants

@kmuehlbauer@dcherian@jhamman