Uh oh!
There was an error while loading. Please reload this page.
unify freq strings (independent of pd version) - #8627
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
… into unify_freq_strings
Co-authored-by: Spencer Clark <spencerkclark@gmail.com>
mathause
commented
Jan 22, 2024
Some more updates. I think this needs more work still. But to make sure I don't forget: I don't update the following line: Line 330 in 5a92d48 There is a test with a negative frequency ( Should |
spencerkclark
commented
Jan 23, 2024
Thanks @mathause — it does seem reasonable to update our |
mathause
commented
Feb 12, 2024
I am marking this ready to review. |
spencerkclark
left a comment
There was a problem hiding this comment.
Thanks @mathause—I think this looks good. Awesome that this enables us to silence all the frequency-string-related deprecation warnings in the test suite too!
I'm approving, but could you just add an additional test for both _legacy_to_new_freq and _new_to_legacy_freq that a pandas-only offset string gets passed through unmodified without raising an error?
max-sixty
commented
Feb 15, 2024
Thanks a lot @mathause ! |
whats-new.rstapi.rstProbably not ready for review yet.