Uh oh!
There was an error while loading. Please reload this page.
Use np.real and np.imag when possible - #9368
Open
Illviljan wants to merge 9 commits into
Open
Conversation
for more information, see https://pre-commit.ci
Uh oh!
There was an error while loading. Please reload this page.
Illviljan
marked this pull request as ready for review
August 15, 2024 21:05
Illviljan
commented
Aug 15, 2024
ContributorAuthor
flaky? |
TomNicholas
commented
Aug 16, 2024
Member
Everything "dask roundtrip" seems to be somewhat flaky in my experience. |
max-sixty
commented
Aug 16, 2024
Collaborator
(I would be +1 on xfailing anything like that, not as good as fixing but better than letting it break some reasonably high % of CI...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces NamedArray's minimum requirements for a
duckarray.For example
pd.Indexdoesn't have.realand.imag(or__array_function__/__array_namespace__unfortunately, a problem for another PR...).xref: #9314