Skip to content

Implement DataTree.__delitem__ - #9453

Merged
TomNicholas merged 8 commits into
pydata:mainfrom
TomNicholas:delitem
Sep 9, 2024
Merged

Implement DataTree.__delitem__#9453
TomNicholas merged 8 commits into
pydata:mainfrom
TomNicholas:delitem

Conversation

@TomNicholas

Copy link
Copy Markdown
Member

@TomNicholasTomNicholas added the topic-DataTree Related to the implementation of a DataTree class label Sep 8, 2024
Comment threadxarray/core/datatree.py Outdated
Comment threadxarray/core/treenode.py Outdated
@TomNicholas
TomNicholas enabled auto-merge (squash) September 9, 2024 15:09
@TomNicholas
TomNicholas merged commit 45a0027 into pydata:mainSep 9, 2024
@TomNicholas
TomNicholas deleted the delitem branch September 9, 2024 15:36
@TomNicholasTomNicholas mentioned this pull request Sep 12, 2024
27 tasks
dcherian added a commit to dcherian/xarray that referenced this pull request Sep 17, 2024
* main: (26 commits)
Forbid modifying names of DataTree objects with parents (pydata#9494)
DAS-2155 - Merge datatree documentation into main docs. (pydata#9033)
Make illegal path-like variable names when constructing a DataTree from a Dataset (pydata#9378)
Ensure TreeNode doesn't copy in-place (pydata#9482)
`open_groups` for zarr backends (pydata#9469)
Update pyproject.toml (pydata#9484)
New whatsnew section (pydata#9483)
Release notes for v2024.09.0 (pydata#9480)
Fix `DataTree.coords.__setitem__` by adding `DataTreeCoordinates` class (pydata#9451)
Rename DataTree's "ds" and "data" to "dataset" (pydata#9476)
Update DataTree repr to indicate inheritance (pydata#9470)
Bump pypa/gh-action-pypi-publish in the actions group (pydata#9460)
Repo checker (pydata#9450)
Add days_in_year and decimal_year to dt accessor (pydata#9105)
remove parent argument from DataTree.__init__ (pydata#9465)
Fix inheritance in DataTree.copy() (pydata#9457)
Implement `DataTree.__delitem__` (pydata#9453)
Add ASV for datatree.from_dict (pydata#9459)
Make the first argument in DataTree.from_dict positional only (pydata#9446)
Fix typos across the code, doc and comments (pydata#9443)
...
dcherian added a commit to dcherian/xarray that referenced this pull request Sep 17, 2024
* main: (29 commits)
Release notes for v2024.09.0 (pydata#9480)
Fix `DataTree.coords.__setitem__` by adding `DataTreeCoordinates` class (pydata#9451)
Rename DataTree's "ds" and "data" to "dataset" (pydata#9476)
Update DataTree repr to indicate inheritance (pydata#9470)
Bump pypa/gh-action-pypi-publish in the actions group (pydata#9460)
Repo checker (pydata#9450)
Add days_in_year and decimal_year to dt accessor (pydata#9105)
remove parent argument from DataTree.__init__ (pydata#9465)
Fix inheritance in DataTree.copy() (pydata#9457)
Implement `DataTree.__delitem__` (pydata#9453)
Add ASV for datatree.from_dict (pydata#9459)
Make the first argument in DataTree.from_dict positional only (pydata#9446)
Fix typos across the code, doc and comments (pydata#9443)
DataTree should not be "Generic" (pydata#9445)
Disallow passing a DataArray as data into the DataTree constructor (pydata#9444)
Support additional dtypes in `resample` (pydata#9413)
Shallow copy parent and children in DataTree constructor (pydata#9297)
Bump minimum versions for dependencies (pydata#9434)
Always include at least one category in random test data (pydata#9436)
Avoid deep-copy when constructing groupby codes (pydata#9429)
...
hollymandel pushed a commit to hollymandel/xarray that referenced this pull request Sep 23, 2024
* test
* improve error message
* implement delitem
* test KeyError
* Remove special KeyError message
Co-authored-by: Stephan Hoyer <shoyer@google.com>
* remove another special KeyError message
Co-authored-by: Stephan Hoyer <shoyer@google.com>
* fix pytest raises expected error message
---------
Co-authored-by: Stephan Hoyer <shoyer@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic-DataTreeRelated to the implementation of a DataTree class

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataTree.__delitem__ should support deleting variables, not only child nodes

2 participants

@TomNicholas@shoyer