Uh oh!
There was an error while loading. Please reload this page.
Compatibility with Zarr v3b2 - #9795
Conversation
| @@ -1126,13 +1128,11 @@ def _create_cf_dataset(): | |||
| def test_grid_mapping_and_bounds_are_not_coordinates_in_file(self) -> None: | |||
There was a problem hiding this comment.
Some of these CF convention handling test really only need to be run with one backend.
cc @kmuehlbauer in case that interests you. Similarly with the "coordinates" roundtripping
* main: Bump codecov/codecov-action from 4.6.0 to 5.0.2 in the actions group (pydata#9793) Buffer types (pydata#9787)
I did some refactoring to fix a test. As an upside, I think we now more efficient when overwriting existing variables. |
| import zarr | ||
| existing_keys = tuple(self.zarr_group.array_keys()) | ||
| if self._mode == "w": |
There was a problem hiding this comment.
logic change. We now skip all these checks for mode="w". i think earlier, zarr would erase the group so all the logic below was not activated. Now that zarr does not erase the group, we must skip all the logic below.
| def sync(self): | ||
| pass | ||
| def _open_existing_array(self, *, name) -> ZarrArray: |
There was a problem hiding this comment.
just moved it around so set_variables is easier to follow
| return zarr_array | ||
| def _create_new_array( |
There was a problem hiding this comment.
just moved it around so set_variables is easier to follow
| "get": 10, | ||
| "list_dir": 3, | ||
| "list_prefix": 0, | ||
| "list_prefix": 4, |
There was a problem hiding this comment.
wild. zarr is calling list_prefix(prefix='') twice on group open; and then listing each variable:
listing ''
listing ''
listing 'x/'
listing 'foo/'
cc @d-v-b
There was a problem hiding this comment.
weird! that's definitely not needed
dcherian
commented
Nov 18, 2024
Remaining upstream failures are zarr-developers/zarr-python#2501 and that we seem to now have 4 new |
dcherian
commented
Nov 21, 2024
Merging tomorrow if there are no comments. There are no functional changes here just adapting to zarr's |
Closes#9277