Skip to content

time coding refactor - #9906

Merged
dcherian merged 17 commits into
pydata:mainfrom
kmuehlbauer:time-decoding-refactor
Jan 2, 2025
Merged

time coding refactor#9906
dcherian merged 17 commits into
pydata:mainfrom
kmuehlbauer:time-decoding-refactor

Conversation

@kmuehlbauer

@kmuehlbauerkmuehlbauer commented Dec 18, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

This introduces some changes in the encoding/decoding pipeline to prepare for other units beside ns. It also fixes some inconsistencies wrt the exact ns.resolution datetime64 bounds.

Finally it will reduce the "noise" over in #9618 quite substantial.

  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

@kmuehlbauerkmuehlbauer mentioned this pull request Dec 18, 2024
Merged
9 tasks
@kmuehlbauer
kmuehlbauer marked this pull request as ready for review December 18, 2024 13:47
kmuehlbauer
kmuehlbauer commented Dec 18, 2024
View reviewed changes
Comment threaddoc/whats-new.rst Outdated
kmuehlbauer
kmuehlbauer commented Dec 18, 2024
View reviewed changes
Comment threadxarray/coding/times.py Outdated
spencerkclark
spencerkclark reviewed Dec 27, 2024
View reviewed changes

@spencerkclarkspencerkclark left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting this off @kmuehlbauer—these changes look good. Just a few very minor questions.

Comment threadxarray/coding/times.py Outdated
Comment threadxarray/coding/times.py Outdated
Comment threadxarray/coding/times.py
Comment threadxarray/coding/times.py Outdated
@kmuehlbauer

kmuehlbauer commented Dec 29, 2024

Copy link
Copy Markdown
ContributorAuthor

@spencerkclark Thanks very much for the review. I've addressed according to your suggestions.

spencerkclark
spencerkclark approved these changes Dec 29, 2024
View reviewed changes

@spencerkclarkspencerkclark left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Comment threadxarray/coding/times.py Outdated
@kmuehlbauer

kmuehlbauer commented Jan 2, 2025

Copy link
Copy Markdown
ContributorAuthor

Thanks @spencerkclark for the review. I think, I've addressed the review items. Planning to merge this early next week.

@kmuehlbauerkmuehlbauer added the plan to merge Final call for comments label Jan 2, 2025
headtr1ck
headtr1ck approved these changes Jan 2, 2025
View reviewed changes

@headtr1ckheadtr1ck left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My brain hurts from trying to understand the differences between numpy and pandas times...

Thanks for the typing!

Comment threadxarray/core/pdcompat.py Outdated
Comment threadxarray/core/pdcompat.py Outdated
Comment threadxarray/coding/times.py Outdated
@kmuehlbauer

kmuehlbauer commented Jan 2, 2025

Copy link
Copy Markdown
ContributorAuthor

Thanks @headtr1ck for the review ❤️!

@dcherian
dcherian merged commit 3fd79ac into pydata:mainJan 2, 2025
@kmuehlbauer
kmuehlbauer deleted the time-decoding-refactor branch January 2, 2025 16:45
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 19, 2025
@dcherian
Merge branch 'main' into custom-groupers
9f3c270
* main: (63 commits)
Fix zarr upstream tests (pydata#9927)
Update pre-commit hooks (pydata#9925)
split out CFDatetimeCoder, deprecate use_cftime as kwarg (pydata#9901)
dev whats-new (pydata#9923)
Whats-new 2025.01.0 (pydata#9919)
Silence upstream Zarr warnings (pydata#9920)
time coding refactor (pydata#9906)
fix warning from scipy backend guess_can_open on directory (pydata#9911)
Enhance and move ISO-8601 parser to coding.times (pydata#9899)
Edit serialization error message (pydata#9916)
friendlier error messages for missing chunk managers (pydata#9676)
Bump codecov/codecov-action from 5.1.1 to 5.1.2 in the actions group (pydata#9915)
Rewrite interp to use `apply_ufunc` (pydata#9881)
Skip dask rolling (pydata#9909)
Explicitly configure ReadTheDocs build to use conf.py (pydata#9908)
Cache pre-existing Zarr arrays in Zarr backend (pydata#9861)
Optimize idxmin, idxmax with dask (pydata#9800)
remove unused "type: ignore" comments in test_plot.py (fixed in matplotlib 3.10.0) (pydata#9904)
move scalar-handling logic into `possibly_convert_objects` (pydata#9900)
Add missing DataTree attributes to docs (pydata#9876)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spencerkclarkspencerkclarkspencerkclark approved these changes
@headtr1ckheadtr1ckheadtr1ck approved these changes

Assignees

No one assigned

Labels

plan to mergeFinal call for comments

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kmuehlbauer@spencerkclark@headtr1ck@dcherian