Add additional tests to improve coverage#464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-janssen merged 2 commits into from
Oct 29, 2024
Merged

Add additional tests to improve coverage #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5e6d81
Add additional tests to improve coverage
jan-janssen Oct 29, 2024
95cd990
Merge remote-tracking branch 'origin/main' into test
jan-janssen Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/test_cache_executor_serial.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -167,6 +167,12 @@ def test_executor_function_dependence_args(self):
q.put({"shutdown": True, "wait": True})
process.join()

def test_execute_in_subprocess_errors(self):
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")

Comment on lines +170 to +175

@coderabbitaicoderabbitaiBotOct 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider enhancing test coverage with additional cases.

While the current test covers basic error handling, consider adding:

  1. A docstring explaining the test's purpose
  2. Validation of error message content
  3. Additional invalid command scenarios

Here's a suggested enhancement:

 def test_execute_in_subprocess_errors(self):
+ """Test that execute_in_subprocess properly handles invalid inputs."""
with self.assertRaises(ValueError):
- execute_in_subprocess(command=[], config_directory="test")+ execute_in_subprocess(command=[], config_directory="test")++ with self.assertRaises(ValueError) as cm:+ execute_in_subprocess(command=None)+ self.assertIn("command cannot be empty", str(cm.exception))+
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
++ with self.assertRaises(TypeError):+ execute_in_subprocess(command="not_a_list")
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
deftest_execute_in_subprocess_errors(self):
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
deftest_execute_in_subprocess_errors(self):
"""Test that execute_in_subprocess properly handles invalid inputs."""
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
withself.assertRaises(ValueError) ascm:
execute_in_subprocess(command=None)
self.assertIn("command cannot be empty", str(cm.exception))
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
withself.assertRaises(TypeError):
execute_in_subprocess(command="not_a_list")

def tearDown(self):
if os.path.exists("cache"):
shutil.rmtree("cache")
11 changes: 10 additions & 1 deletion tests/test_cache_hdf.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@


try:
from executorlib.standalone.hdf import dump, load
from executorlib.standalone.hdf import dump, load, get_output

skip_h5py_test = False
except ImportError:
Expand DownExpand Up@@ -33,6 +33,9 @@ def test_hdf_mixed(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], [a])
self.assertEqual(data_dict["kwargs"], {"b": b})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def test_hdf_args(self):
cache_directory = os.path.abspath("cache")
Expand All@@ -45,6 +48,9 @@ def test_hdf_args(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], [a, b])
self.assertEqual(data_dict["kwargs"], {})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def test_hdf_kwargs(self):
cache_directory = os.path.abspath("cache")
Expand All@@ -60,6 +66,9 @@ def test_hdf_kwargs(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], ())
self.assertEqual(data_dict["kwargs"], {"a": a, "b": b})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def tearDown(self):
if os.path.exists("cache"):
Expand Down
18 changes: 17 additions & 1 deletion tests/test_executor_backend_mpi_noblock.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,11 +13,27 @@ def resource_dict(resource_dict):


class TestExecutorBackend(unittest.TestCase):
def test_meta_executor_serial(self):
def test_meta_executor_serial_with_dependencies(self):
with Executor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) as exe:
cloudpickle_register(ind=1)
fs_1 = exe.submit(calc, 1)
fs_2 = exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

Comment on lines +16 to +30

@coderabbitaicoderabbitaiBotOct 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Method name contradicts the test configuration

The method name test_meta_executor_serial_with_dependencies suggests testing with dependencies enabled, but disable_dependencies=True does the opposite. Consider renaming to test_meta_executor_serial_disabled_dependencies for clarity.

- def test_meta_executor_serial_with_dependencies(self):+ def test_meta_executor_serial_disabled_dependencies(self):
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
deftest_meta_executor_serial_with_dependencies(self):
withExecutor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) asexe:
cloudpickle_register(ind=1)
fs_1=exe.submit(calc, 1)
fs_2=exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())
deftest_meta_executor_serial_disabled_dependencies(self):
withExecutor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) asexe:
cloudpickle_register(ind=1)
fs_1=exe.submit(calc, 1)
fs_2=exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

def test_meta_executor_serial_without_dependencies(self):
with Executor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=False,
) as exe:
cloudpickle_register(ind=1)
fs_1 = exe.submit(calc, 1)
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Add additional tests to improve coverage#464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-janssen merged 2 commits into from
Oct 29, 2024
Merged

Add additional tests to improve coverage #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5e6d81
Add additional tests to improve coverage
jan-janssen Oct 29, 2024
95cd990
Merge remote-tracking branch 'origin/main' into test
jan-janssen Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/test_cache_executor_serial.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -167,6 +167,12 @@ def test_executor_function_dependence_args(self):
q.put({"shutdown": True, "wait": True})
process.join()

def test_execute_in_subprocess_errors(self):
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")

Comment on lines +170 to +175

@coderabbitaicoderabbitaiBotOct 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider enhancing test coverage with additional cases.

While the current test covers basic error handling, consider adding:

  1. A docstring explaining the test's purpose
  2. Validation of error message content
  3. Additional invalid command scenarios

Here's a suggested enhancement:

 def test_execute_in_subprocess_errors(self):
+ """Test that execute_in_subprocess properly handles invalid inputs."""
with self.assertRaises(ValueError):
- execute_in_subprocess(command=[], config_directory="test")+ execute_in_subprocess(command=[], config_directory="test")++ with self.assertRaises(ValueError) as cm:+ execute_in_subprocess(command=None)+ self.assertIn("command cannot be empty", str(cm.exception))+
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
++ with self.assertRaises(TypeError):+ execute_in_subprocess(command="not_a_list")
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
deftest_execute_in_subprocess_errors(self):
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
deftest_execute_in_subprocess_errors(self):
"""Test that execute_in_subprocess properly handles invalid inputs."""
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
withself.assertRaises(ValueError) ascm:
execute_in_subprocess(command=None)
self.assertIn("command cannot be empty", str(cm.exception))
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
withself.assertRaises(TypeError):
execute_in_subprocess(command="not_a_list")

def tearDown(self):
if os.path.exists("cache"):
shutil.rmtree("cache")
11 changes: 10 additions & 1 deletion tests/test_cache_hdf.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@


try:
from executorlib.standalone.hdf import dump, load
from executorlib.standalone.hdf import dump, load, get_output

skip_h5py_test = False
except ImportError:
Expand DownExpand Up@@ -33,6 +33,9 @@ def test_hdf_mixed(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], [a])
self.assertEqual(data_dict["kwargs"], {"b": b})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def test_hdf_args(self):
cache_directory = os.path.abspath("cache")
Expand All@@ -45,6 +48,9 @@ def test_hdf_args(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], [a, b])
self.assertEqual(data_dict["kwargs"], {})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def test_hdf_kwargs(self):
cache_directory = os.path.abspath("cache")
Expand All@@ -60,6 +66,9 @@ def test_hdf_kwargs(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], ())
self.assertEqual(data_dict["kwargs"], {"a": a, "b": b})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def tearDown(self):
if os.path.exists("cache"):
Expand Down
18 changes: 17 additions & 1 deletion tests/test_executor_backend_mpi_noblock.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,11 +13,27 @@ def resource_dict(resource_dict):


class TestExecutorBackend(unittest.TestCase):
def test_meta_executor_serial(self):
def test_meta_executor_serial_with_dependencies(self):
with Executor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) as exe:
cloudpickle_register(ind=1)
fs_1 = exe.submit(calc, 1)
fs_2 = exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

Comment on lines +16 to +30

@coderabbitaicoderabbitaiBotOct 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Method name contradicts the test configuration

The method name test_meta_executor_serial_with_dependencies suggests testing with dependencies enabled, but disable_dependencies=True does the opposite. Consider renaming to test_meta_executor_serial_disabled_dependencies for clarity.

- def test_meta_executor_serial_with_dependencies(self):+ def test_meta_executor_serial_disabled_dependencies(self):
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
deftest_meta_executor_serial_with_dependencies(self):
withExecutor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) asexe:
cloudpickle_register(ind=1)
fs_1=exe.submit(calc, 1)
fs_2=exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())
deftest_meta_executor_serial_disabled_dependencies(self):
withExecutor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) asexe:
cloudpickle_register(ind=1)
fs_1=exe.submit(calc, 1)
fs_2=exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

def test_meta_executor_serial_without_dependencies(self):
with Executor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=False,
) as exe:
cloudpickle_register(ind=1)
fs_1 = exe.submit(calc, 1)
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add additional tests to improve coverage#464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-janssen merged 2 commits into from
Oct 29, 2024
Merged

Add additional tests to improve coverage #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5e6d81
Add additional tests to improve coverage
jan-janssen Oct 29, 2024
95cd990
Merge remote-tracking branch 'origin/main' into test
jan-janssen Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/test_cache_executor_serial.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -167,6 +167,12 @@ def test_executor_function_dependence_args(self):
q.put({"shutdown": True, "wait": True})
process.join()

def test_execute_in_subprocess_errors(self):
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")

Comment on lines +170 to +175

@coderabbitaicoderabbitaiBotOct 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider enhancing test coverage with additional cases.

While the current test covers basic error handling, consider adding:

  1. A docstring explaining the test's purpose
  2. Validation of error message content
  3. Additional invalid command scenarios

Here's a suggested enhancement:

 def test_execute_in_subprocess_errors(self):
+ """Test that execute_in_subprocess properly handles invalid inputs."""
with self.assertRaises(ValueError):
- execute_in_subprocess(command=[], config_directory="test")+ execute_in_subprocess(command=[], config_directory="test")++ with self.assertRaises(ValueError) as cm:+ execute_in_subprocess(command=None)+ self.assertIn("command cannot be empty", str(cm.exception))+
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
++ with self.assertRaises(TypeError):+ execute_in_subprocess(command="not_a_list")
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
deftest_execute_in_subprocess_errors(self):
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
deftest_execute_in_subprocess_errors(self):
"""Test that execute_in_subprocess properly handles invalid inputs."""
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
withself.assertRaises(ValueError) ascm:
execute_in_subprocess(command=None)
self.assertIn("command cannot be empty", str(cm.exception))
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
withself.assertRaises(TypeError):
execute_in_subprocess(command="not_a_list")

def tearDown(self):
if os.path.exists("cache"):
shutil.rmtree("cache")
11 changes: 10 additions & 1 deletion tests/test_cache_hdf.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@


try:
from executorlib.standalone.hdf import dump, load
from executorlib.standalone.hdf import dump, load, get_output

skip_h5py_test = False
except ImportError:
Expand DownExpand Up@@ -33,6 +33,9 @@ def test_hdf_mixed(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], [a])
self.assertEqual(data_dict["kwargs"], {"b": b})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def test_hdf_args(self):
cache_directory = os.path.abspath("cache")
Expand All@@ -45,6 +48,9 @@ def test_hdf_args(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], [a, b])
self.assertEqual(data_dict["kwargs"], {})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def test_hdf_kwargs(self):
cache_directory = os.path.abspath("cache")
Expand All@@ -60,6 +66,9 @@ def test_hdf_kwargs(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], ())
self.assertEqual(data_dict["kwargs"], {"a": a, "b": b})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def tearDown(self):
if os.path.exists("cache"):
Expand Down
18 changes: 17 additions & 1 deletion tests/test_executor_backend_mpi_noblock.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,11 +13,27 @@ def resource_dict(resource_dict):


class TestExecutorBackend(unittest.TestCase):
def test_meta_executor_serial(self):
def test_meta_executor_serial_with_dependencies(self):
with Executor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) as exe:
cloudpickle_register(ind=1)
fs_1 = exe.submit(calc, 1)
fs_2 = exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

Comment on lines +16 to +30

@coderabbitaicoderabbitaiBotOct 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Method name contradicts the test configuration

The method name test_meta_executor_serial_with_dependencies suggests testing with dependencies enabled, but disable_dependencies=True does the opposite. Consider renaming to test_meta_executor_serial_disabled_dependencies for clarity.

- def test_meta_executor_serial_with_dependencies(self):+ def test_meta_executor_serial_disabled_dependencies(self):
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
deftest_meta_executor_serial_with_dependencies(self):
withExecutor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) asexe:
cloudpickle_register(ind=1)
fs_1=exe.submit(calc, 1)
fs_2=exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())
deftest_meta_executor_serial_disabled_dependencies(self):
withExecutor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) asexe:
cloudpickle_register(ind=1)
fs_1=exe.submit(calc, 1)
fs_2=exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

def test_meta_executor_serial_without_dependencies(self):
with Executor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=False,
) as exe:
cloudpickle_register(ind=1)
fs_1 = exe.submit(calc, 1)
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add additional tests to improve coverage#464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-janssen merged 2 commits into from
Oct 29, 2024
Merged

Add additional tests to improve coverage #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5e6d81
Add additional tests to improve coverage
jan-janssen Oct 29, 2024
95cd990
Merge remote-tracking branch 'origin/main' into test
jan-janssen Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/test_cache_executor_serial.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -167,6 +167,12 @@ def test_executor_function_dependence_args(self):
q.put({"shutdown": True, "wait": True})
process.join()

def test_execute_in_subprocess_errors(self):
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")

Comment on lines +170 to +175

@coderabbitaicoderabbitaiBotOct 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider enhancing test coverage with additional cases.

While the current test covers basic error handling, consider adding:

  1. A docstring explaining the test's purpose
  2. Validation of error message content
  3. Additional invalid command scenarios

Here's a suggested enhancement:

 def test_execute_in_subprocess_errors(self):
+ """Test that execute_in_subprocess properly handles invalid inputs."""
with self.assertRaises(ValueError):
- execute_in_subprocess(command=[], config_directory="test")+ execute_in_subprocess(command=[], config_directory="test")++ with self.assertRaises(ValueError) as cm:+ execute_in_subprocess(command=None)+ self.assertIn("command cannot be empty", str(cm.exception))+
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
++ with self.assertRaises(TypeError):+ execute_in_subprocess(command="not_a_list")
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
deftest_execute_in_subprocess_errors(self):
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
deftest_execute_in_subprocess_errors(self):
"""Test that execute_in_subprocess properly handles invalid inputs."""
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
withself.assertRaises(ValueError) ascm:
execute_in_subprocess(command=None)
self.assertIn("command cannot be empty", str(cm.exception))
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
withself.assertRaises(TypeError):
execute_in_subprocess(command="not_a_list")

def tearDown(self):
if os.path.exists("cache"):
shutil.rmtree("cache")
11 changes: 10 additions & 1 deletion tests/test_cache_hdf.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@


try:
from executorlib.standalone.hdf import dump, load
from executorlib.standalone.hdf import dump, load, get_output

skip_h5py_test = False
except ImportError:
Expand DownExpand Up@@ -33,6 +33,9 @@ def test_hdf_mixed(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], [a])
self.assertEqual(data_dict["kwargs"], {"b": b})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def test_hdf_args(self):
cache_directory = os.path.abspath("cache")
Expand All@@ -45,6 +48,9 @@ def test_hdf_args(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], [a, b])
self.assertEqual(data_dict["kwargs"], {})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def test_hdf_kwargs(self):
cache_directory = os.path.abspath("cache")
Expand All@@ -60,6 +66,9 @@ def test_hdf_kwargs(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], ())
self.assertEqual(data_dict["kwargs"], {"a": a, "b": b})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def tearDown(self):
if os.path.exists("cache"):
Expand Down
18 changes: 17 additions & 1 deletion tests/test_executor_backend_mpi_noblock.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,11 +13,27 @@ def resource_dict(resource_dict):


class TestExecutorBackend(unittest.TestCase):
def test_meta_executor_serial(self):
def test_meta_executor_serial_with_dependencies(self):
with Executor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) as exe:
cloudpickle_register(ind=1)
fs_1 = exe.submit(calc, 1)
fs_2 = exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

Comment on lines +16 to +30

@coderabbitaicoderabbitaiBotOct 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Method name contradicts the test configuration

The method name test_meta_executor_serial_with_dependencies suggests testing with dependencies enabled, but disable_dependencies=True does the opposite. Consider renaming to test_meta_executor_serial_disabled_dependencies for clarity.

- def test_meta_executor_serial_with_dependencies(self):+ def test_meta_executor_serial_disabled_dependencies(self):
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
deftest_meta_executor_serial_with_dependencies(self):
withExecutor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) asexe:
cloudpickle_register(ind=1)
fs_1=exe.submit(calc, 1)
fs_2=exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())
deftest_meta_executor_serial_disabled_dependencies(self):
withExecutor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) asexe:
cloudpickle_register(ind=1)
fs_1=exe.submit(calc, 1)
fs_2=exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

def test_meta_executor_serial_without_dependencies(self):
with Executor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=False,
) as exe:
cloudpickle_register(ind=1)
fs_1 = exe.submit(calc, 1)
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Add additional tests to improve coverage#464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-janssen merged 2 commits into from
Oct 29, 2024
Merged

Add additional tests to improve coverage #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5e6d81
Add additional tests to improve coverage
jan-janssen Oct 29, 2024
95cd990
Merge remote-tracking branch 'origin/main' into test
jan-janssen Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/test_cache_executor_serial.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -167,6 +167,12 @@ def test_executor_function_dependence_args(self):
q.put({"shutdown": True, "wait": True})
process.join()

def test_execute_in_subprocess_errors(self):
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")

Comment on lines +170 to +175

@coderabbitaicoderabbitaiBotOct 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider enhancing test coverage with additional cases.

While the current test covers basic error handling, consider adding:

  1. A docstring explaining the test's purpose
  2. Validation of error message content
  3. Additional invalid command scenarios

Here's a suggested enhancement:

 def test_execute_in_subprocess_errors(self):
+ """Test that execute_in_subprocess properly handles invalid inputs."""
with self.assertRaises(ValueError):
- execute_in_subprocess(command=[], config_directory="test")+ execute_in_subprocess(command=[], config_directory="test")++ with self.assertRaises(ValueError) as cm:+ execute_in_subprocess(command=None)+ self.assertIn("command cannot be empty", str(cm.exception))+
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
++ with self.assertRaises(TypeError):+ execute_in_subprocess(command="not_a_list")
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
deftest_execute_in_subprocess_errors(self):
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
deftest_execute_in_subprocess_errors(self):
"""Test that execute_in_subprocess properly handles invalid inputs."""
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
withself.assertRaises(ValueError) ascm:
execute_in_subprocess(command=None)
self.assertIn("command cannot be empty", str(cm.exception))
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
withself.assertRaises(TypeError):
execute_in_subprocess(command="not_a_list")

def tearDown(self):
if os.path.exists("cache"):
shutil.rmtree("cache")
11 changes: 10 additions & 1 deletion tests/test_cache_hdf.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@


try:
from executorlib.standalone.hdf import dump, load
from executorlib.standalone.hdf import dump, load, get_output

skip_h5py_test = False
except ImportError:
Expand DownExpand Up@@ -33,6 +33,9 @@ def test_hdf_mixed(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], [a])
self.assertEqual(data_dict["kwargs"], {"b": b})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def test_hdf_args(self):
cache_directory = os.path.abspath("cache")
Expand All@@ -45,6 +48,9 @@ def test_hdf_args(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], [a, b])
self.assertEqual(data_dict["kwargs"], {})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def test_hdf_kwargs(self):
cache_directory = os.path.abspath("cache")
Expand All@@ -60,6 +66,9 @@ def test_hdf_kwargs(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], ())
self.assertEqual(data_dict["kwargs"], {"a": a, "b": b})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def tearDown(self):
if os.path.exists("cache"):
Expand Down
18 changes: 17 additions & 1 deletion tests/test_executor_backend_mpi_noblock.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,11 +13,27 @@ def resource_dict(resource_dict):


class TestExecutorBackend(unittest.TestCase):
def test_meta_executor_serial(self):
def test_meta_executor_serial_with_dependencies(self):
with Executor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) as exe:
cloudpickle_register(ind=1)
fs_1 = exe.submit(calc, 1)
fs_2 = exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

Comment on lines +16 to +30

@coderabbitaicoderabbitaiBotOct 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Method name contradicts the test configuration

The method name test_meta_executor_serial_with_dependencies suggests testing with dependencies enabled, but disable_dependencies=True does the opposite. Consider renaming to test_meta_executor_serial_disabled_dependencies for clarity.

- def test_meta_executor_serial_with_dependencies(self):+ def test_meta_executor_serial_disabled_dependencies(self):
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
deftest_meta_executor_serial_with_dependencies(self):
withExecutor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) asexe:
cloudpickle_register(ind=1)
fs_1=exe.submit(calc, 1)
fs_2=exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())
deftest_meta_executor_serial_disabled_dependencies(self):
withExecutor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) asexe:
cloudpickle_register(ind=1)
fs_1=exe.submit(calc, 1)
fs_2=exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

def test_meta_executor_serial_without_dependencies(self):
with Executor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=False,
) as exe:
cloudpickle_register(ind=1)
fs_1 = exe.submit(calc, 1)
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add additional tests to improve coverage#464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-janssen merged 2 commits into from
Oct 29, 2024
Merged

Add additional tests to improve coverage #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5e6d81
Add additional tests to improve coverage
jan-janssen Oct 29, 2024
95cd990
Merge remote-tracking branch 'origin/main' into test
jan-janssen Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/test_cache_executor_serial.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -167,6 +167,12 @@ def test_executor_function_dependence_args(self):
q.put({"shutdown": True, "wait": True})
process.join()

def test_execute_in_subprocess_errors(self):
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")

Comment on lines +170 to +175

@coderabbitaicoderabbitaiBotOct 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider enhancing test coverage with additional cases.

While the current test covers basic error handling, consider adding:

  1. A docstring explaining the test's purpose
  2. Validation of error message content
  3. Additional invalid command scenarios

Here's a suggested enhancement:

 def test_execute_in_subprocess_errors(self):
+ """Test that execute_in_subprocess properly handles invalid inputs."""
with self.assertRaises(ValueError):
- execute_in_subprocess(command=[], config_directory="test")+ execute_in_subprocess(command=[], config_directory="test")++ with self.assertRaises(ValueError) as cm:+ execute_in_subprocess(command=None)+ self.assertIn("command cannot be empty", str(cm.exception))+
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
++ with self.assertRaises(TypeError):+ execute_in_subprocess(command="not_a_list")
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
deftest_execute_in_subprocess_errors(self):
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
deftest_execute_in_subprocess_errors(self):
"""Test that execute_in_subprocess properly handles invalid inputs."""
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
withself.assertRaises(ValueError) ascm:
execute_in_subprocess(command=None)
self.assertIn("command cannot be empty", str(cm.exception))
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
withself.assertRaises(TypeError):
execute_in_subprocess(command="not_a_list")

def tearDown(self):
if os.path.exists("cache"):
shutil.rmtree("cache")
11 changes: 10 additions & 1 deletion tests/test_cache_hdf.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@


try:
from executorlib.standalone.hdf import dump, load
from executorlib.standalone.hdf import dump, load, get_output

skip_h5py_test = False
except ImportError:
Expand DownExpand Up@@ -33,6 +33,9 @@ def test_hdf_mixed(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], [a])
self.assertEqual(data_dict["kwargs"], {"b": b})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def test_hdf_args(self):
cache_directory = os.path.abspath("cache")
Expand All@@ -45,6 +48,9 @@ def test_hdf_args(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], [a, b])
self.assertEqual(data_dict["kwargs"], {})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def test_hdf_kwargs(self):
cache_directory = os.path.abspath("cache")
Expand All@@ -60,6 +66,9 @@ def test_hdf_kwargs(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], ())
self.assertEqual(data_dict["kwargs"], {"a": a, "b": b})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def tearDown(self):
if os.path.exists("cache"):
Expand Down
18 changes: 17 additions & 1 deletion tests/test_executor_backend_mpi_noblock.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,11 +13,27 @@ def resource_dict(resource_dict):


class TestExecutorBackend(unittest.TestCase):
def test_meta_executor_serial(self):
def test_meta_executor_serial_with_dependencies(self):
with Executor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) as exe:
cloudpickle_register(ind=1)
fs_1 = exe.submit(calc, 1)
fs_2 = exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

Comment on lines +16 to +30

@coderabbitaicoderabbitaiBotOct 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Method name contradicts the test configuration

The method name test_meta_executor_serial_with_dependencies suggests testing with dependencies enabled, but disable_dependencies=True does the opposite. Consider renaming to test_meta_executor_serial_disabled_dependencies for clarity.

- def test_meta_executor_serial_with_dependencies(self):+ def test_meta_executor_serial_disabled_dependencies(self):
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
deftest_meta_executor_serial_with_dependencies(self):
withExecutor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) asexe:
cloudpickle_register(ind=1)
fs_1=exe.submit(calc, 1)
fs_2=exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())
deftest_meta_executor_serial_disabled_dependencies(self):
withExecutor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) asexe:
cloudpickle_register(ind=1)
fs_1=exe.submit(calc, 1)
fs_2=exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

def test_meta_executor_serial_without_dependencies(self):
with Executor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=False,
) as exe:
cloudpickle_register(ind=1)
fs_1 = exe.submit(calc, 1)
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add additional tests to improve coverage#464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-janssen merged 2 commits into from
Oct 29, 2024
Merged

Add additional tests to improve coverage #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5e6d81
Add additional tests to improve coverage
jan-janssen Oct 29, 2024
95cd990
Merge remote-tracking branch 'origin/main' into test
jan-janssen Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/test_cache_executor_serial.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -167,6 +167,12 @@ def test_executor_function_dependence_args(self):
q.put({"shutdown": True, "wait": True})
process.join()

def test_execute_in_subprocess_errors(self):
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")

Comment on lines +170 to +175

@coderabbitaicoderabbitaiBotOct 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider enhancing test coverage with additional cases.

While the current test covers basic error handling, consider adding:

  1. A docstring explaining the test's purpose
  2. Validation of error message content
  3. Additional invalid command scenarios

Here's a suggested enhancement:

 def test_execute_in_subprocess_errors(self):
+ """Test that execute_in_subprocess properly handles invalid inputs."""
with self.assertRaises(ValueError):
- execute_in_subprocess(command=[], config_directory="test")+ execute_in_subprocess(command=[], config_directory="test")++ with self.assertRaises(ValueError) as cm:+ execute_in_subprocess(command=None)+ self.assertIn("command cannot be empty", str(cm.exception))+
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
++ with self.assertRaises(TypeError):+ execute_in_subprocess(command="not_a_list")
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
deftest_execute_in_subprocess_errors(self):
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
deftest_execute_in_subprocess_errors(self):
"""Test that execute_in_subprocess properly handles invalid inputs."""
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
withself.assertRaises(ValueError) ascm:
execute_in_subprocess(command=None)
self.assertIn("command cannot be empty", str(cm.exception))
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
withself.assertRaises(TypeError):
execute_in_subprocess(command="not_a_list")

def tearDown(self):
if os.path.exists("cache"):
shutil.rmtree("cache")
11 changes: 10 additions & 1 deletion tests/test_cache_hdf.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@


try:
from executorlib.standalone.hdf import dump, load
from executorlib.standalone.hdf import dump, load, get_output

skip_h5py_test = False
except ImportError:
Expand DownExpand Up@@ -33,6 +33,9 @@ def test_hdf_mixed(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], [a])
self.assertEqual(data_dict["kwargs"], {"b": b})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def test_hdf_args(self):
cache_directory = os.path.abspath("cache")
Expand All@@ -45,6 +48,9 @@ def test_hdf_args(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], [a, b])
self.assertEqual(data_dict["kwargs"], {})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def test_hdf_kwargs(self):
cache_directory = os.path.abspath("cache")
Expand All@@ -60,6 +66,9 @@ def test_hdf_kwargs(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], ())
self.assertEqual(data_dict["kwargs"], {"a": a, "b": b})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def tearDown(self):
if os.path.exists("cache"):
Expand Down
18 changes: 17 additions & 1 deletion tests/test_executor_backend_mpi_noblock.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,11 +13,27 @@ def resource_dict(resource_dict):


class TestExecutorBackend(unittest.TestCase):
def test_meta_executor_serial(self):
def test_meta_executor_serial_with_dependencies(self):
with Executor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) as exe:
cloudpickle_register(ind=1)
fs_1 = exe.submit(calc, 1)
fs_2 = exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

Comment on lines +16 to +30

@coderabbitaicoderabbitaiBotOct 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Method name contradicts the test configuration

The method name test_meta_executor_serial_with_dependencies suggests testing with dependencies enabled, but disable_dependencies=True does the opposite. Consider renaming to test_meta_executor_serial_disabled_dependencies for clarity.

- def test_meta_executor_serial_with_dependencies(self):+ def test_meta_executor_serial_disabled_dependencies(self):
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
deftest_meta_executor_serial_with_dependencies(self):
withExecutor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) asexe:
cloudpickle_register(ind=1)
fs_1=exe.submit(calc, 1)
fs_2=exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())
deftest_meta_executor_serial_disabled_dependencies(self):
withExecutor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) asexe:
cloudpickle_register(ind=1)
fs_1=exe.submit(calc, 1)
fs_2=exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

def test_meta_executor_serial_without_dependencies(self):
with Executor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=False,
) as exe:
cloudpickle_register(ind=1)
fs_1 = exe.submit(calc, 1)
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Add additional tests to improve coverage#464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-janssen merged 2 commits into from
Oct 29, 2024
Merged

Add additional tests to improve coverage #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5e6d81
Add additional tests to improve coverage
jan-janssen Oct 29, 2024
95cd990
Merge remote-tracking branch 'origin/main' into test
jan-janssen Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/test_cache_executor_serial.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -167,6 +167,12 @@ def test_executor_function_dependence_args(self):
q.put({"shutdown": True, "wait": True})
process.join()

def test_execute_in_subprocess_errors(self):
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")

Comment on lines +170 to +175

@coderabbitaicoderabbitaiBotOct 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider enhancing test coverage with additional cases.

While the current test covers basic error handling, consider adding:

  1. A docstring explaining the test's purpose
  2. Validation of error message content
  3. Additional invalid command scenarios

Here's a suggested enhancement:

 def test_execute_in_subprocess_errors(self):
+ """Test that execute_in_subprocess properly handles invalid inputs."""
with self.assertRaises(ValueError):
- execute_in_subprocess(command=[], config_directory="test")+ execute_in_subprocess(command=[], config_directory="test")++ with self.assertRaises(ValueError) as cm:+ execute_in_subprocess(command=None)+ self.assertIn("command cannot be empty", str(cm.exception))+
with self.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
++ with self.assertRaises(TypeError):+ execute_in_subprocess(command="not_a_list")
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
deftest_execute_in_subprocess_errors(self):
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
deftest_execute_in_subprocess_errors(self):
"""Test that execute_in_subprocess properly handles invalid inputs."""
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], config_directory="test")
withself.assertRaises(ValueError) ascm:
execute_in_subprocess(command=None)
self.assertIn("command cannot be empty", str(cm.exception))
withself.assertRaises(ValueError):
execute_in_subprocess(command=[], backend="flux")
withself.assertRaises(TypeError):
execute_in_subprocess(command="not_a_list")

def tearDown(self):
if os.path.exists("cache"):
shutil.rmtree("cache")
11 changes: 10 additions & 1 deletion tests/test_cache_hdf.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@


try:
from executorlib.standalone.hdf import dump, load
from executorlib.standalone.hdf import dump, load, get_output

skip_h5py_test = False
except ImportError:
Expand DownExpand Up@@ -33,6 +33,9 @@ def test_hdf_mixed(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], [a])
self.assertEqual(data_dict["kwargs"], {"b": b})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def test_hdf_args(self):
cache_directory = os.path.abspath("cache")
Expand All@@ -45,6 +48,9 @@ def test_hdf_args(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], [a, b])
self.assertEqual(data_dict["kwargs"], {})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def test_hdf_kwargs(self):
cache_directory = os.path.abspath("cache")
Expand All@@ -60,6 +66,9 @@ def test_hdf_kwargs(self):
self.assertTrue("fn" in data_dict.keys())
self.assertEqual(data_dict["args"], ())
self.assertEqual(data_dict["kwargs"], {"a": a, "b": b})
flag, output = get_output(file_name=file_name)
self.assertFalse(flag)
self.assertIsNone(output)

def tearDown(self):
if os.path.exists("cache"):
Expand Down
18 changes: 17 additions & 1 deletion tests/test_executor_backend_mpi_noblock.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,11 +13,27 @@ def resource_dict(resource_dict):


class TestExecutorBackend(unittest.TestCase):
def test_meta_executor_serial(self):
def test_meta_executor_serial_with_dependencies(self):
with Executor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) as exe:
cloudpickle_register(ind=1)
fs_1 = exe.submit(calc, 1)
fs_2 = exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

Comment on lines +16 to +30

@coderabbitaicoderabbitaiBotOct 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Method name contradicts the test configuration

The method name test_meta_executor_serial_with_dependencies suggests testing with dependencies enabled, but disable_dependencies=True does the opposite. Consider renaming to test_meta_executor_serial_disabled_dependencies for clarity.

- def test_meta_executor_serial_with_dependencies(self):+ def test_meta_executor_serial_disabled_dependencies(self):
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
deftest_meta_executor_serial_with_dependencies(self):
withExecutor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) asexe:
cloudpickle_register(ind=1)
fs_1=exe.submit(calc, 1)
fs_2=exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())
deftest_meta_executor_serial_disabled_dependencies(self):
withExecutor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=True,
) asexe:
cloudpickle_register(ind=1)
fs_1=exe.submit(calc, 1)
fs_2=exe.submit(calc, 2)
self.assertEqual(fs_1.result(), 1)
self.assertEqual(fs_2.result(), 2)
self.assertTrue(fs_1.done())
self.assertTrue(fs_2.done())

def test_meta_executor_serial_without_dependencies(self):
with Executor(
max_cores=2,
backend="local",
block_allocation=False,
disable_dependencies=False,
) as exe:
cloudpickle_register(ind=1)
fs_1 = exe.submit(calc, 1)
Expand Down